Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3467)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2715433008: 🏡 Add a ChromeHomeNewTabPage (Closed)
Patch Set: Cancel inprogress animation when FBV disabled Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index 3ef166ec2c7e1510cedfdb5097ed1c9361ec035f..c566a2a72d1aa6ab217e6274f346ab6a20ec78d7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -53,8 +53,6 @@ import org.chromium.chrome.browser.util.ViewUtils;
import org.chromium.chrome.browser.widget.displaystyle.UiConfig;
import org.chromium.ui.base.DeviceFormFactor;
-import jp.tomorrowkey.android.gifplayer.BaseGifImage;
-
/**
* The native new tab page, represented by some basic data such as title and url, and an Android
* View that displays the page.
@@ -101,6 +99,7 @@ public class NewTabPageView
private ChromeActivity mActivity;
private NewTabPageManager mManager;
+ private LogoView.Delegate mLogoDelegate;
private TileGroup.Delegate mTileGroupDelegate;
private TileGroup mTileGroup;
private UiConfig mUiConfig;
@@ -149,18 +148,6 @@ public class NewTabPageView
void focusSearchBox(boolean beginVoiceSearch, String pastedText);
/**
- * Called when the user clicks on the logo.
- * @param isAnimatedLogoShowing Whether the animated GIF logo is playing.
- */
- void onLogoClicked(boolean isAnimatedLogoShowing);
-
- /**
- * Gets the default search provider's logo and calls logoObserver with the result.
- * @param logoObserver The callback to notify when the logo is available.
- */
- void getSearchProviderLogo(LogoObserver logoObserver);
-
- /**
* @return whether the {@link NewTabPage} associated with this manager is the current page
* displayed to the user.
*/
@@ -246,6 +233,7 @@ public class NewTabPageView
mSearchProviderLogoView =
(LogoView) mNewTabPageLayout.findViewById(R.id.search_provider_logo);
+ mLogoDelegate = new LogoDelegateImpl(tab, mSearchProviderLogoView);
mSearchBoxView = mNewTabPageLayout.findViewById(R.id.search_box);
mNoSearchLogoSpacer = mNewTabPageLayout.findViewById(R.id.no_search_logo_spacer);
@@ -507,11 +495,11 @@ public class NewTabPageView
* Loads the search provider logo (e.g. Google doodle), if any.
*/
private void loadSearchProviderLogo() {
- mManager.getSearchProviderLogo(new LogoObserver() {
+ mLogoDelegate.getSearchProviderLogo(new LogoObserver() {
@Override
public void onLogoAvailable(Logo logo, boolean fromCache) {
if (logo == null && fromCache) return;
- mSearchProviderLogoView.setMananger(mManager);
+ mSearchProviderLogoView.setDelegate(mLogoDelegate);
mSearchProviderLogoView.updateLogo(logo);
mSnapshotTileGridChanged = true;
}
@@ -570,20 +558,6 @@ public class NewTabPageView
}
/**
- * Shows a progressbar indicating the animated logo is being downloaded.
- */
- void showLogoLoadingView() {
- mSearchProviderLogoView.showLoadingView();
- }
-
- /**
- * Starts playing the given animated GIF logo.
- */
- void playAnimatedLogo(BaseGifImage gifImage) {
- mSearchProviderLogoView.playAnimatedLogo(gifImage);
- }
-
- /**
* @return Whether URL focus animations are currently disabled.
*/
boolean urlFocusAnimationsDisabled() {

Powered by Google App Engine
This is Rietveld 408576698