chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java - Issue 2715433008: 🏡 Add a ChromeHomeNewTabPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

Issue 2715433008: 🏡 Add a ChromeHomeNewTabPage (Closed)

Patch Set: Cancel inprogress animation when FBV disabled Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

index 1974177c15594a6f2e92f89b80162911e0754f43..a15bb6ca35d9e2654cad1cc7d86bb67850c59aec 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

@@ -22,6 +22,7 @@ import org.chromium.chrome.browser.physicalweb.PhysicalWebDiagnosticsPage;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.TabModel;

import org.chromium.chrome.browser.tabmodel.TabModelSelector;

+import org.chromium.chrome.browser.util.FeatureUtilities;

import org.chromium.content_public.browser.LoadUrlParams;

/**

@@ -34,7 +35,9 @@ public class NativePageFactory {

static class NativePageBuilder {

protected NativePage buildNewTabPage(ChromeActivity activity, Tab tab,

TabModelSelector tabModelSelector) {

- if (tab.isIncognito()) {

+ if (FeatureUtilities.isChromeHomeEnabled() && !tab.isIncognito()) {

+ return new ChromeHomeNewTabPage(activity, tab, tabModelSelector);

+ } else if (tab.isIncognito()) {

return new IncognitoNewTabPage(activity);

} else {

return new NewTabPage(activity, new TabShim(tab), tabModelSelector);