Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2651)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java

Issue 2715433008: 🏡 Add a ChromeHomeNewTabPage (Closed)
Patch Set: Cancel inprogress animation when FBV disabled Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java
index 18bc4d3ab4741f42678806ad3651bcdd260af0d0..48cdfe9a4b14ea9fc57c11bf018fb2456e2c9f53 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java
@@ -33,6 +33,7 @@ import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModel;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.tabmodel.TabModelUtils;
+import org.chromium.chrome.browser.util.FeatureUtilities;
import org.chromium.chrome.browser.util.MathUtils;
import org.chromium.ui.base.LocalizationUtils;
import org.chromium.ui.resources.ResourceManager;
@@ -246,6 +247,12 @@ public class StackLayout extends Layout implements Animatable<StackLayout.Proper
startMarginAnimation(false);
startYOffsetAnimation(false);
finishScrollStacks();
+
+ // TODO(twellington): Add a proper tab selection animation rather than disabling the current
+ // animation.
+ if (FeatureUtilities.isChromeHomeEnabled()) {
+ onUpdateAnimation(System.currentTimeMillis(), true);
+ }
}
@Override
@@ -346,6 +353,12 @@ public class StackLayout extends Layout implements Animatable<StackLayout.Proper
mStacks[getTabStackIndex(id)].tabCreated(time, id);
startMarginAnimation(false);
uiPreemptivelySelectTabModel(newIsIncognito);
+
+ // TODO(twellington): Add a proper tab creation animation rather than disabling the current
+ // animation.
+ if (FeatureUtilities.isChromeHomeEnabled()) {
+ onUpdateAnimation(System.currentTimeMillis(), true);
+ }
}
@Override

Powered by Google App Engine
This is Rietveld 408576698