chrome/android/java/res/layout/chrome_home_new_tab_page.xml - Issue 2715433008: 🏡 Add a ChromeHomeNewTabPage

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/chrome_home_new_tab_page.xml

Issue 2715433008: 🏡 Add a ChromeHomeNewTabPage (Closed)

Patch Set: Changes from mdjones@ review Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPage.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <RelativeLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	9 android:layout_width="match_parent"

	10 android:layout_height="match_parent"

	11 android:focusable="true"
	dgn 2017/02/28 14:09:56 why make it focusable? is that related to accessib why make it focusable? is that related to accessibility? Theresa 2017/02/28 17:02:23 If it's not focusable then the toolbar/omnibox get Show quoted text On 2017/02/28 14:09:56, dgn wrote: > why make it focusable? is that related to accessibility? If it's not focusable then the toolbar/omnibox gets focus when an NTP is open. It also allows the full NTP to gain focus when TalkBack is on.
	12 android:focusableInTouchMode="true"

	13 android:background="@color/ntp_bg" >

	14

	15 <org.chromium.chrome.browser.widget.TintedImageButton

	16 android:id="@+id/close_button"

	17 android:layout_width="40dp"

	18 android:layout_height="40dp"

	19 android:layout_alignParentTop="true"

	20 android:layout_alignParentStart="true"

	21 android:src="@drawable/btn_close"

	22 android:scaleType="center"

	23 android:background="@android:color/transparent"

	24 chrome:tint="@color/dark_mode_tint" />

	25

	26 <View

	27 android:id="@+id/centered_view"

	28 android:layout_width="match_parent"

	29 android:layout_height="30dp"

	30 android:layout_centerInParent="true" />

	31

	32 <org.chromium.chrome.browser.ntp.LogoView

	33 android:id="@+id/search_provider_logo"

	34 android:layout_width="match_parent"

	35 android:layout_height="@dimen/ntp_logo_height"

	36 android:padding="16dp"

	37 android:layout_marginEnd="16dp"

	38 android:layout_marginBottom="16dp"

	39 android:layout_marginTop="16dp"

	40 android:layout_above="@id/centered_view" />

	41

	42 </RelativeLayout>

OLD	NEW