Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.h

Issue 2715433006: [Offline Pages] Turn Offliner::Cancel into an async operation to resolve conflicting assumptions (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.h
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.h b/chrome/browser/android/offline_pages/prerendering_offliner.h
index 45eca74c5270792822dd410b0433ee1ee0b222e6..9faf9c13f9c8d11d864ce0c52f8a8d2d3983c9d3 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.h
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.h
@@ -36,7 +36,7 @@ class PrerenderingOffliner : public Offliner {
// Offliner implementation.
bool LoadAndSave(const SavePageRequest& request,
const CompletionCallback& callback) override;
- void Cancel() override;
+ void Cancel(const CancelCallback& callback) override;
// Allows a loader to be injected for testing. This may only be done once
// and must be called before any of the Offliner interface methods are called.
@@ -72,6 +72,8 @@ class PrerenderingOffliner : public Offliner {
// Listener function for changes to application background/foreground state.
void OnApplicationStateChange(
base::android::ApplicationState application_state);
+ void HandleApplicationStateChangeCancel(const SavePageRequest& request,
+ int64_t offline_id);
// Not owned.
content::BrowserContext* browser_context_;

Powered by Google App Engine
This is Rietveld 408576698