Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1903)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.h

Issue 2715433006: [Offline Pages] Turn Offliner::Cancel into an async operation to resolve conflicting assumptions (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner.h
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.h b/chrome/browser/android/offline_pages/background_loader_offliner.h
index f9c9002c9112a082a4c785002dafe4f6b4e0aad1..c4728ee8fa60a9f5ddc0fd9b077a2951235483a2 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.h
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.h
@@ -37,7 +37,7 @@ class BackgroundLoaderOffliner : public Offliner,
// Offliner implementation.
bool LoadAndSave(const SavePageRequest& request,
const CompletionCallback& callback) override;
- void Cancel() override;
+ void Cancel(const CancelCallback& callback) override;
// WebContentsObserver implementation.
void DidStopLoading() override;
@@ -62,6 +62,8 @@ class BackgroundLoaderOffliner : public Offliner,
// Called when application state has changed.
void OnApplicationStateChange(
base::android::ApplicationState application_state);
+ void HandleApplicationStateChangeCancel(const SavePageRequest& request,
+ int64_t offline_id);
std::unique_ptr<background_loader::BackgroundLoaderContents> loader_;
// Not owned.
@@ -76,11 +78,15 @@ class BackgroundLoaderOffliner : public Offliner,
std::unique_ptr<base::android::ApplicationStatusListener> app_listener_;
// Whether we are on a low-end device.
bool is_low_end_device_;
+
// Save state.
SaveState save_state_;
// Page load state.
PageLoadState page_load_state_;
+ // Callback for cancel.
+ CancelCallback cancel_callback_;
+
base::WeakPtrFactory<BackgroundLoaderOffliner> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(BackgroundLoaderOffliner);
};

Powered by Google App Engine
This is Rietveld 408576698