Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 271543009: Send the device scale factor from Windows 8 ASH during initialization via the MetroViewerHostMsg_Se… (Closed)

Created:
6 years, 7 months ago by ananta
Modified:
6 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews, kalyank, ben+aura_chromium.org, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Send the device scale factor from Windows 8 ASH during initialization via the MetroViewerHostMsg_SetTargetSurface IPC message. cpu, please review everything. sky, please review the ash/chrome/ui portions. I added a dependency on gfx in the metro_driver project for a subsequent change to send the correct device scale factor on Windows 8 as the metro API does not appear to work correctly causing text, etc to appear very small on high dpi monitors with scales above 125%. BUG=371219 R=cpu,sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269993

Patch Set 1 #

Patch Set 2 : Reverted changes to printed_document_win.cc #

Total comments: 2

Patch Set 3 : Code review comments #

Patch Set 4 : Fixed build error #

Patch Set 5 : Removed references to GetModernUIScale #

Patch Set 6 : GetDPIscale returns the global scale factor #

Total comments: 2

Patch Set 7 : Removed tabs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -66 lines) Patch
M ash/display/display_info.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_metro_viewer_process_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M ash/test/test_metro_viewer_process_host.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
M ui/aura/remote_window_tree_host_win.h View 1 chunk +7 lines, -4 lines 0 comments Download
M ui/aura/remote_window_tree_host_win.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M ui/base/win/dpi_setup.cc View 1 chunk +1 line, -9 lines 0 comments Download
M ui/gfx/win/dpi.h View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M ui/gfx/win/dpi.cc View 1 2 3 4 5 2 chunks +6 lines, -23 lines 0 comments Download
M ui/metro_viewer/metro_viewer_messages.h View 1 chunk +3 lines, -2 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.h View 1 chunk +3 lines, -0 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 1 4 chunks +8 lines, -2 lines 0 comments Download
M win8/metro_driver/display_properties.cc View 1 2 2 chunks +2 lines, -9 lines 0 comments Download
M win8/metro_driver/metro_driver.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
ananta
6 years, 7 months ago (2014-05-08 02:20:14 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-08 15:53:53 UTC) #2
cpu_(ooo_6.6-7.5)
I was expecting to see a removal of a LoadLibrary somewhere.. https://codereview.chromium.org/271543009/diff/20001/win8/metro_driver/display_properties.cc File win8/metro_driver/display_properties.cc (right): ...
6 years, 7 months ago (2014-05-08 21:42:37 UTC) #3
ananta
Removed GetModernUIScale and its descendants which load the metro driver, etc. https://codereview.chromium.org/271543009/diff/20001/win8/metro_driver/display_properties.cc File win8/metro_driver/display_properties.cc (right): ...
6 years, 7 months ago (2014-05-08 22:51:42 UTC) #4
ananta
On 2014/05/08 22:51:42, ananta wrote: > Removed GetModernUIScale and its descendants which load the metro ...
6 years, 7 months ago (2014-05-09 00:03:49 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm with one nit. https://codereview.chromium.org/271543009/diff/100001/win8/metro_driver/metro_driver.gyp File win8/metro_driver/metro_driver.gyp (right): https://codereview.chromium.org/271543009/diff/100001/win8/metro_driver/metro_driver.gyp#newcode76 win8/metro_driver/metro_driver.gyp:76: '../../ui/gfx/gfx.gyp:gfx', space (or tabs)issue here.
6 years, 7 months ago (2014-05-10 02:31:15 UTC) #6
ananta
https://codereview.chromium.org/271543009/diff/100001/win8/metro_driver/metro_driver.gyp File win8/metro_driver/metro_driver.gyp (right): https://codereview.chromium.org/271543009/diff/100001/win8/metro_driver/metro_driver.gyp#newcode76 win8/metro_driver/metro_driver.gyp:76: '../../ui/gfx/gfx.gyp:gfx', On 2014/05/10 02:31:15, cpu wrote: > space (or ...
6 years, 7 months ago (2014-05-10 02:48:02 UTC) #7
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 7 months ago (2014-05-12 19:43:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/271543009/120001
6 years, 7 months ago (2014-05-12 19:44:55 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 03:35:04 UTC) #10
Message was sent while issue was closed. 
Change committed as 269993

Powered by Google App Engine
This is Rietveld 408576698