src/arm64/regexp-macro-assembler-arm64.cc - Issue 271543004: Reland - Arm64: Ensure that csp is always aligned to 16 byte values even if jssp is not.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/regexp-macro-assembler-arm64.cc

Issue 271543004: Reland - Arm64: Ensure that csp is always aligned to 16 byte values even if jssp is not. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Use macro-assembler Sub() in BumpSystemStackPointer where possible and only do csp alignment check … Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/regexp-macro-assembler-arm64.cc

diff --git a/src/arm64/regexp-macro-assembler-arm64.cc b/src/arm64/regexp-macro-assembler-arm64.cc

index 97040cf75eb3c02662ed99bc685ebe0decabd40a..576d49b0f48b05ed6b2a604f2192795ff4df5283 100644

--- a/src/arm64/regexp-macro-assembler-arm64.cc

+++ b/src/arm64/regexp-macro-assembler-arm64.cc

@@ -976,6 +976,7 @@ Handle<HeapObject> RegExpMacroAssemblerARM64::GetCode(Handle<String> source) {

// Set stack pointer back to first register to retain

ASSERT(csp.Is(__ StackPointer()));

__ Mov(csp, fp);

+ __ AssertStackConsistency(true);

// Restore registers.

__ PopCPURegList(registers_to_retain);

« src/arm64/macro-assembler-arm64-inl.h ('K') | « src/arm64/macro-assembler-arm64-inl.h ('k') | src/builtins.cc » ('j') | no next file with comments »