Reland - Arm64: Ensure that csp is always aligned to 16 byte values even if jssp is not.

test/cctest/test-assembler-arm64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 8366 matching lines @@
 // proper word-endian behaviour.
 static void PushPopJsspSimpleHelper(int reg_count,
                                     int claim,
                                     int reg_size,
                                     PushPopMethod push_method,
                                     PushPopMethod pop_method) {
   SETUP();
 
   START();
 
-  // Registers x8 and x9 are used by the macro assembler for debug code (for
+  // Registers ip0 and ip1 are used by the macro assembler for debug code (for
   // example in 'Pop'), so we can't use them here. We can't use jssp because it
   // will be the stack pointer for this test.
-  static RegList const allowed = ~(x8.Bit() | x9.Bit() | jssp.Bit());
+  static RegList const allowed = ~(ip0.Bit() | ip1.Bit() | jssp.Bit());

[rmcilroy, 2014/05/09 11:18:46]

One last change required here - I think this is a leftover from when you were
using x8/x9 instead of ip0/ip1 as default tmp registers.

[jbramley, 2014/05/09 11:23:51]

We used x8/x9 _and_ ip0/ip1: ip0/ip1 were for general MacroAssembler utilities,
and x8/x9 were used in debug code only (and rarely). Since it worked before, we
should be able to remove them from this mask entirely. It might be a good idea
to clear TmpList() to be safe.

[rmcilroy, 2014/05/09 11:30:56]

The reason this fails now without this change is because a tmp from tmplist (ip0
or ip1) will be used to align csp during the push/pops.  I could clear Tmplist
and remove these from mask such that it falls back to the no-tmp available
branch in BumpSystemStackPointer -  would you prefer I did this?

   if (reg_count == kPushPopJsspMaxRegCount) {
     reg_count = CountSetBits(allowed, kNumberOfRegisters);
   }
   // Work out which registers to use, based on reg_size.
   Register r[kNumberOfRegisters];
   Register x[kNumberOfRegisters];
   RegList list = PopulateRegisterArray(NULL, x, r, reg_size, reg_count,
                                        allowed);
 
   // The literal base is chosen to have two useful properties:
@@ skipping 2557 matching lines @@
     if (RelocInfo::IsVeneerPool(info->rmode())) {
       ASSERT(info->data() == veneer_pool_size);
       ++pool_count;
     }
   }
 
   ASSERT(pool_count == 2);
 
   TEARDOWN();
 }