Issue 271543003: Don't deref ChildThread::current() when null (it can be null in some tests)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271543003: Don't deref ChildThread::current() when null (it can be null in some tests) (Closed)

Created:
6 years, 7 months ago by kinuko

Modified:
6 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Don't deref ChildThread::current() when null (it can be null in some tests) http://crrev.com/263143004 changes the timing when we call RenderFrameImpl::createServiceWorkerProvider, and with the patch we can hit ChildThread::current() == NULL case in some content_browsertests [1]. [1] sample crash log without this fix: http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/2962/steps/content_browsertests/logs/stdio BUG=366063 TEST=content_browsertests with http://crrev.com/263143004 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268833

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	content/renderer/render_frame_impl.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

kinuko

Jochen: could you review this? (This one was necessary to safely land: https://codereview.chromium.org/263143004)

6 years, 7 months ago (2014-05-07 14:56:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/271543003/1

6 years, 7 months ago (2014-05-07 15:04:04 UTC) #4

kinuko

6 years, 7 months ago (2014-05-07 16:59:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r268833 (presubmit successful).