Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2715423004: DevTools: add coverage snapshots

Created:
3 years, 9 months ago by caseq
Modified:
3 years, 9 months ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add coverage snapshots BUG=

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -23 lines) Patch
A third_party/WebKit/LayoutTests/inspector/coverage/coverage-view-snapshot.html View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/coverage/coverage-view-snapshot-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 2 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/toolbarButtonGlyphs.svg View 2 chunks +26 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs.png View Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png View Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js View 1 4 chunks +35 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/coverage/module.json View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
caseq
3 years, 9 months ago (2017-02-28 20:35:34 UTC) #2
alph
lgtm https://codereview.chromium.org/2715423004/diff/1/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/2715423004/diff/1/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp#newcode2422 third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:2422: for (Document* document : m_domAgent->documents()) nit: auto* https://codereview.chromium.org/2715423004/diff/1/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js ...
3 years, 9 months ago (2017-02-28 22:01:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715423004/20001
3 years, 9 months ago (2017-03-01 00:15:50 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 01:11:14 UTC) #8 
Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698