Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: content/browser/loader/downloaded_temp_file_impl.h

Issue 2715423003: [Mojo-Loading] Use independent URLLoaderClient (Closed)
Patch Set: fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/loader/downloaded_temp_file_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/downloaded_temp_file_impl.h
diff --git a/content/browser/loader/downloaded_temp_file_impl.h b/content/browser/loader/downloaded_temp_file_impl.h
index b8b5aad084e3fe5a73b8a969fa6dfda64e2e2edc..9f7f31dc430e52d0ef76ff5d6b631e8b18ca45c6 100644
--- a/content/browser/loader/downloaded_temp_file_impl.h
+++ b/content/browser/loader/downloaded_temp_file_impl.h
@@ -17,18 +17,12 @@ namespace content {
class CONTENT_EXPORT DownloadedTempFileImpl final
: public mojom::DownloadedTempFile {
public:
- // Creates a DownloadedTempFileImpl, binds it as a strong associated
+ // Creates a DownloadedTempFileImpl, binds it as a strong
// interface, and returns the interface ptr info to be passed to the client.
yzshen1 2017/02/28 17:56:33 nit: please remove "info"
yhirano 2017/03/01 00:53:43 Done.
// That means:
// * The DownloadedTempFile object created here is essentially owned by the
// client. It keeps alive until the client destroys the other endpoint.
- // * The resulting interface will be associated to the same message pipe on
- // which the returned pointer info object is sent.
- static mojom::DownloadedTempFileAssociatedPtrInfo Create(int child_id,
- int request_id);
-
- static mojom::DownloadedTempFilePtr CreateForTesting(int child_id,
- int request_id);
+ static mojom::DownloadedTempFilePtr Create(int child_id, int request_id);
DownloadedTempFileImpl(int child_id, int request_id);
~DownloadedTempFileImpl() override;
« no previous file with comments | « no previous file | content/browser/loader/downloaded_temp_file_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698