Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.cc

Issue 2715423003: [Mojo-Loading] Use independent URLLoaderClient (Closed)
Patch Set: fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_fetch_dispatcher.cc
diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.cc b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
index be41aa95de6203d05814549934aa47209b443f86..7017787fc0db354558c02f84c6423dbdc2aefdf5 100644
--- a/content/browser/service_worker/service_worker_fetch_dispatcher.cc
+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
@@ -27,7 +27,6 @@
#include "content/common/service_worker/service_worker_utils.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/common/browser_side_navigation_policy.h"
-#include "mojo/public/cpp/bindings/associated_binding.h"
#include "mojo/public/cpp/bindings/binding.h"
#include "net/base/request_priority.h"
#include "net/http/http_util.h"
@@ -158,7 +157,7 @@ class DelegatingURLLoaderClient final : public mojom::URLLoaderClient {
}
void OnReceiveResponse(
const ResourceResponseHead& head,
- mojom::DownloadedTempFileAssociatedPtrInfo downloaded_file) override {
+ mojom::DownloadedTempFilePtr downloaded_file) override {
client_->OnReceiveResponse(head, std::move(downloaded_file));
DCHECK(on_response_);
std::move(on_response_).Run();
@@ -181,9 +180,7 @@ class DelegatingURLLoaderClient final : public mojom::URLLoaderClient {
base::Bind(&NotifyNavigationPreloadCompletedOnUI, completion_status));
}
- void Bind(mojom::URLLoaderClientAssociatedPtrInfo* ptr_info) {
- binding_.Bind(ptr_info);
- }
+ void Bind(mojom::URLLoaderClientPtr* ptr_info) { binding_.Bind(ptr_info); }
private:
void MayBeRunDevToolsCallbacks() {
@@ -202,7 +199,7 @@ class DelegatingURLLoaderClient final : public mojom::URLLoaderClient {
MayBeRunDevToolsCallbacks();
}
- mojo::AssociatedBinding<mojom::URLLoaderClient> binding_;
+ mojo::Binding<mojom::URLLoaderClient> binding_;
mojom::URLLoaderClientPtr client_;
base::OnceClosure on_response_;
bool completed_ = false;
@@ -582,14 +579,14 @@ bool ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(
mojo::MakeRequest(&url_loader_client_ptr);
auto url_loader_client = base::MakeUnique<DelegatingURLLoaderClient>(
std::move(url_loader_client_ptr), std::move(on_response), request);
- mojom::URLLoaderClientAssociatedPtrInfo url_loader_client_associated_ptr_info;
- url_loader_client->Bind(&url_loader_client_associated_ptr_info);
+ mojom::URLLoaderClientPtr url_loader_client_ptr_to_pass;
+ url_loader_client->Bind(&url_loader_client_ptr_to_pass);
mojom::URLLoaderAssociatedPtr url_loader_associated_ptr;
url_loader_factory->CreateLoaderAndStart(
mojo::MakeRequest(&url_loader_associated_ptr),
original_info->GetRouteID(), request_id, request,
- std::move(url_loader_client_associated_ptr_info));
+ std::move(url_loader_client_ptr_to_pass));
std::unique_ptr<DelegatingURLLoader> url_loader(
base::MakeUnique<DelegatingURLLoader>(

Powered by Google App Engine
This is Rietveld 408576698