Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: chrome/browser/resources/settings/device_page/device_page.html

Issue 2715403005: MD Settings Fix associated-control for bluetooth, people, device subpage (Closed)
Patch Set: Make quick ulock subpages no-search Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/device_page.html
diff --git a/chrome/browser/resources/settings/device_page/device_page.html b/chrome/browser/resources/settings/device_page/device_page.html
index c71eb7866fb533d037e5e5d296fbd905a08bf158..2913bfb420cccb493bb47ca867583061b2ff20bd 100644
--- a/chrome/browser/resources/settings/device_page/device_page.html
+++ b/chrome/browser/resources/settings/device_page/device_page.html
@@ -36,14 +36,12 @@
<button class="subpage-arrow" is="paper-icon-button-light"
aria-label="$i18n{keyboardTitle}"></button>
</div>
- <template is="dom-if" if="[[hasStylus_]]">
- <div id="stylusRow" class="settings-box" on-tap="onStylusTap_"
- actionable>
- <div class="start">$i18n{stylusTitle}</div>
+ <div id="stylusRow" class="settings-box" on-tap="onStylusTap_"
dpapad 2017/03/01 02:08:05 Is this change from dom-if to hidden necessary?
stevenjb 2017/03/01 16:49:57 Actually, no. I thought it was before I thought to
+ actionable hidden$="[[!hasStylus_]]">
+ <div class="start">$i18n{stylusTitle}</div>
<button class="subpage-arrow" is="paper-icon-button-light"
aria-label="$i18n{stylusTitle}"></button>
- </div>
- </template>
+ </div>
<div id="displayRow" class="settings-box" on-tap="onDisplayTap_"
actionable>
<div class="start">$i18n{displayTitle}</div>
@@ -101,7 +99,7 @@
<settings-keyboard prefs="{{prefs}}"></settings-keyboard>
</settings-subpage>
</template>
- <template is="dom-if" route-path="/stylus">
+ <template is="dom-if" route-path="/stylus" no-search$="[[!hasStylus_]]">
<settings-subpage
associated-control="[[$$('#stylusRow')]]"
page-title="$i18n{stylusTitle}">

Powered by Google App Engine
This is Rietveld 408576698