Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2462)

Unified Diff: chrome/common/extensions/extension_process_policy.cc

Issue 2715363002: Enable Isolate Extensions by default. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_process_policy.cc
diff --git a/chrome/common/extensions/extension_process_policy.cc b/chrome/common/extensions/extension_process_policy.cc
index 59fb528efd9031584886a596fefe89828bc9aaf7..333a34de76790ef25be44539939b1cc9690b7a68 100644
--- a/chrome/common/extensions/extension_process_policy.cc
+++ b/chrome/common/extensions/extension_process_policy.cc
@@ -79,8 +79,14 @@ bool IsIsolateExtensionsEnabled() {
const std::string group_name =
base::FieldTrialList::FindFullName("SiteIsolationExtensions");
// Use StartsWith() for more flexibility (e.g. multiple Enabled groups).
- return base::StartsWith(group_name, "Enabled",
- base::CompareCase::INSENSITIVE_ASCII);
+ bool control_group = base::StartsWith(group_name, "Control",
+ base::CompareCase::INSENSITIVE_ASCII);
+ bool default_group = base::StartsWith(group_name, "Default",
+ base::CompareCase::INSENSITIVE_ASCII);
+ if (control_group || default_group)
Devlin 2017/02/27 19:27:22 It's strange to me that the default_group behavior
nasko 2017/02/27 19:35:14 Yes, naming is hard ... the "default" group should
+ return false;
+
+ return true;
}
} // namespace extensions
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698