Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: ios/web_view/public/cwv_ui_delegate.h

Issue 2715343002: Add JavaScript prompts support to CWVUIDelegate. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/public/cwv_ui_delegate.h
diff --git a/ios/web_view/public/cwv_ui_delegate.h b/ios/web_view/public/cwv_ui_delegate.h
index 79de5853167b1d692e410d2c3c057bf06b1bfd2e..87f29c2933828a39174607351a3176e861da1a36 100644
--- a/ios/web_view/public/cwv_ui_delegate.h
+++ b/ios/web_view/public/cwv_ui_delegate.h
@@ -26,6 +26,31 @@
inView:(UIView*)view
userGestureLocation:(CGPoint)location;
+// Instructs the delegate to show UI in response to window.alert JavaScript
+// call.
+- (void)webView:(CWVWebView*)webView
+ runJavaScriptAlertPanelWithMessage:(NSString*)message
+ pageURL:(NSURL*)URL
+ completionHandler:(void (^)(void))handler;
Eugene But (OOO till 7-30) 2017/02/27 18:30:52 s/handler/completionHandler
michaeldo 2017/02/27 21:35:51 Done.
+
+// Instructs the delegate to show UI in response to
+// window.confirm JavaScript call.
+- (void)webView:(CWVWebView*)webView
+ runJavaScriptConfirmPanelWithMessage:(NSString*)message
+ pageURL:(NSURL*)URL
+ completionHandler:(void (^)(BOOL))handler;
+
+// Instructs the delegate to show UI in response to window.prompt
+// JavaScript call.
+- (void)webView:(CWVWebView*)webView
+ runJavaScriptTextInputPanelWithPrompt:(NSString*)prompt
+ defaultText:(NSString*)defaultText
+ pageURL:(NSURL*)URL
+ completionHandler:(void (^)(NSString*))handler;
+
+// Instructs the delegate to cancel all current javascript prompts.
+- (void)cancelDialogsForWebView:(CWVWebView*)webView;
Eugene But (OOO till 7-30) 2017/02/27 18:30:52 Can we remove this method? It's quite unclear when
michaeldo 2017/02/27 21:35:51 I have removed this method. It is only called when
Eugene But (OOO till 7-30) 2017/02/27 22:01:05 I still see this method in the header. Please doub
michaeldo 2017/02/27 23:39:15 Done.
+
@end
#endif // IOS_WEB_VIEW_PUBLIC_CWV_UI_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698