Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: src/utils/SkLuaCanvas.cpp

Issue 271533013: Comment out call broken call to pushMatrix in LuaCanvas (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkLuaCanvas.h" 8 #include "SkLuaCanvas.h"
9 #include "SkLua.h" 9 #include "SkLua.h"
10 10
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 break; 115 break;
116 } 116 }
117 case SkMatrix::kScale_Mask: { 117 case SkMatrix::kScale_Mask: {
118 AUTO_LUA("scale"); 118 AUTO_LUA("scale");
119 lua.pushScalar(matrix.getScaleX(), "sx"); 119 lua.pushScalar(matrix.getScaleX(), "sx");
120 lua.pushScalar(matrix.getScaleY(), "sy"); 120 lua.pushScalar(matrix.getScaleY(), "sy");
121 break; 121 break;
122 } 122 }
123 default: { 123 default: {
124 AUTO_LUA("concat"); 124 AUTO_LUA("concat");
125 lua.pushMatrix(matrix); 125 // pushMatrix added in https://codereview.chromium.org/203203004/
126 // Doesn't seem to have ever been working correctly since added
127 // lua.pushMatrix(matrix);
126 break; 128 break;
127 } 129 }
128 } 130 }
129 131
130 this->INHERITED::didConcat(matrix); 132 this->INHERITED::didConcat(matrix);
131 } 133 }
132 134
133 void SkLuaCanvas::didSetMatrix(const SkMatrix& matrix) { 135 void SkLuaCanvas::didSetMatrix(const SkMatrix& matrix) {
134 this->INHERITED::didSetMatrix(matrix); 136 this->INHERITED::didSetMatrix(matrix);
135 } 137 }
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 const SkColor colors[], SkXfermode* xmode, 279 const SkColor colors[], SkXfermode* xmode,
278 const uint16_t indices[], int indexCount, 280 const uint16_t indices[], int indexCount,
279 const SkPaint& paint) { 281 const SkPaint& paint) {
280 AUTO_LUA("drawVertices"); 282 AUTO_LUA("drawVertices");
281 lua.pushPaint(paint, "paint"); 283 lua.pushPaint(paint, "paint");
282 } 284 }
283 285
284 void SkLuaCanvas::drawData(const void* data, size_t length) { 286 void SkLuaCanvas::drawData(const void* data, size_t length) {
285 AUTO_LUA("drawData"); 287 AUTO_LUA("drawData");
286 } 288 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698