cc/layers/picture_layer_impl.h - Issue 271533011: cc: Move tiling management out of draw properties calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_layer_impl.h

Issue 271533011: cc: Move tiling management out of draw properties calculation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + review commnets Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/layers/picture_image_layer_impl_unittest.cc ('K') | « cc/layers/picture_image_layer_impl_unittest.cc ('k') | cc/layers/picture_layer_impl.cc » ('j') | cc/layers/picture_layer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/layers/picture_layer_impl.h

diff --git a/cc/layers/picture_layer_impl.h b/cc/layers/picture_layer_impl.h

index 9609ccf3e449f282ec504f6e35a1001d5a4a93cc..82e3beea79dfeefdb0efd374de52b9a89a7e47ac 100644

--- a/cc/layers/picture_layer_impl.h

+++ b/cc/layers/picture_layer_impl.h

@@ -96,14 +96,6 @@ class CC_EXPORT PictureLayerImpl

virtual void DidBecomeActive() OVERRIDE;

virtual void DidBeginTracing() OVERRIDE;

virtual void ReleaseResources() OVERRIDE;

- virtual void CalculateContentsScale(float ideal_contents_scale,

- float device_scale_factor,

- float page_scale_factor,

- float maximum_animation_contents_scale,

- bool animating_transform_to_screen,

- float* contents_scale_x,

- float* contents_scale_y,

- gfx::Size* content_bounds) OVERRIDE;

virtual skia::RefPtr<SkPicture> GetPicture() OVERRIDE;

// PictureLayerTilingClient overrides.

@@ -180,6 +172,9 @@ class CC_EXPORT PictureLayerImpl

SkColor* color, float* width) const OVERRIDE;

virtual void AsValueInto(base::DictionaryValue* dict) const OVERRIDE;

+ virtual void UpdateIdealScales();

+ float MaximumTilingContentScale() const;

enne (OOO) 2014/06/03 19:14:47 ContentScale => ContentsScale for consistency?

sohanjg 2014/06/04 10:32:41 Done.

PictureLayerImpl* twin_layer_;

scoped_ptr<PictureLayerTilingSet> tilings_;

« cc/layers/picture_image_layer_impl_unittest.cc ('K') | « cc/layers/picture_image_layer_impl_unittest.cc ('k') | cc/layers/picture_layer_impl.cc » ('j') | cc/layers/picture_layer_impl.cc » ('J')