Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1903)

Unified Diff: cc/layers/picture_layer_impl.h

Issue 271533011: cc: Move tiling management out of draw properties calculation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments + unit/perf test fails addressed Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/picture_layer_impl.h
diff --git a/cc/layers/picture_layer_impl.h b/cc/layers/picture_layer_impl.h
index 80d09dde721ad2e533c11d819f4241e986c6327c..0e0c039591e036275f2b7e69a9a0e1caa736a88c 100644
--- a/cc/layers/picture_layer_impl.h
+++ b/cc/layers/picture_layer_impl.h
@@ -97,14 +97,6 @@ class CC_EXPORT PictureLayerImpl
virtual void DidBecomeActive() OVERRIDE;
virtual void DidBeginTracing() OVERRIDE;
virtual void ReleaseResources() OVERRIDE;
- virtual void CalculateContentsScale(float ideal_contents_scale,
- float device_scale_factor,
- float page_scale_factor,
- float maximum_animation_contents_scale,
- bool animating_transform_to_screen,
- float* contents_scale_x,
- float* contents_scale_y,
- gfx::Size* content_bounds) OVERRIDE;
virtual skia::RefPtr<SkPicture> GetPicture() OVERRIDE;
// PictureLayerTilingClient overrides.
@@ -142,6 +134,13 @@ class CC_EXPORT PictureLayerImpl
WhichTree GetTree() const;
bool IsOnActiveOrPendingTree() const;
+ float MaximumTilingContentScale() const;
+ void PopulateSharedQuadStateWithOverrides(
+ SharedQuadState* state,
+ gfx::Transform target_space_transform,
+ gfx::Size content_bounds,
+ gfx::Rect visible_content_rect) const;
+
protected:
friend class LayerRasterTileIterator;
@@ -183,6 +182,8 @@ class CC_EXPORT PictureLayerImpl
bool CanHaveTilingWithScale(float contents_scale) const;
void SanityCheckTilingState() const;
+ void UpdateIdealScales();
+
virtual void GetDebugBorderProperties(
SkColor* color, float* width) const OVERRIDE;
virtual void AsValueInto(base::DictionaryValue* dict) const OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698