cc: Move tiling management out of draw properties calculation.

cc/trees/layer_tree_host_common.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_common.h"
 
 #include <algorithm>
 
 #include "base/debug/trace_event.h"
 #include "cc/base/math_util.h"
@@ skipping 63 matching lines @@
   if (target_surface_rect.Contains(layer_rect_in_target_space))
     return layer_bound_rect;
 
   // If the layer doesn't fill up the entire surface, then find the part of
   // the surface rect where the layer could be visible. This avoids trying to
   // project surface rect points that are behind the projection point.
   gfx::Rect minimal_surface_rect = target_surface_rect;
   minimal_surface_rect.Intersect(layer_rect_in_target_space);
 
   if (minimal_surface_rect.IsEmpty())
-      return gfx::Rect();
+    return gfx::Rect();
 
   // Project the corners of the target surface rect into the layer space.
   // This bounding rectangle may be larger than it needs to be (being
   // axis-aligned), but is a reasonable filter on the space to consider.
   // Non-invertible transforms will create an empty rect here.
 
   gfx::Transform surface_to_layer(gfx::Transform::kSkipInitialization);
   if (!transform.GetInverse(&surface_to_layer)) {
     // Because we cannot use the surface bounds to determine what portion of
     // the layer is visible, we must conservatively assume the full layer is
@@ skipping 1642 matching lines @@
       layer,
       globals.can_adjust_raster_scales,
       ideal_contents_scale,
       globals.device_scale_factor,
       data_from_ancestor.in_subtree_of_page_scale_application_layer
           ? globals.page_scale_factor
           : 1.f,
       combined_maximum_animation_contents_scale,
       animating_transform_to_screen);
 
+  layer_draw_properties.ideal_contents_scale = ideal_contents_scale;

[danakj, 2014/05/21 15:01:00]

Can we add a unit test to layer_tree_host_common_unittest.cc for each of these
new draw properties.

For each one set up a tree so that you get some edge cases for them and verify
the draw properties are being set correctly.

+  layer_draw_properties.maximum_animation_contents_scale =
+      combined_maximum_animation_contents_scale;
+  layer_draw_properties.page_scale =
+      data_from_ancestor.in_subtree_of_page_scale_application_layer
+          ? globals.page_scale_factor
+          : 1.f;
+  layer_draw_properties.device_scale = globals.device_scale_factor;
+
   // The draw_transform that gets computed below is effectively the layer's
   // draw_transform, unless the layer itself creates a render_surface. In that
   // case, the render_surface re-parents the transforms.
   layer_draw_properties.target_space_transform = combined_transform;
   // M[draw] = M[parent] * LT * S[layer2content]
   layer_draw_properties.target_space_transform.Scale(
       SK_MScalar1 / layer->contents_scale_x(),
       SK_MScalar1 / layer->contents_scale_y());
 
   // The layer's screen_space_transform represents the transform between root
@@ skipping 654 matching lines @@
       inputs->current_render_surface_layer_list_id);
 
   // The dummy layer list should not have been used.
   DCHECK_EQ(0u, dummy_layer_list.size());
   // A root layer render_surface should always exist after
   // CalculateDrawProperties.
   DCHECK(inputs->root_layer->render_surface());
 }
 
 }  // namespace cc