VM: remove service_object_patch.dart and all associated code.

VM: remove service_object_patch.dart and all associated code.

This deletion has several reasons:

- This code is broken and refers to non-existant private parts of dart:io
(e.g. `_NativeSocket._sockets`, `_ProcessImpl._processes`, `_RandomAccessFile._files`).

- This code is not reachable through the service protocol. `_serviceObjectHandler` uses
`paths` to fetch the right handler from `_servicePathMap` but caller `ServiceGetIOHandler`
always passes empty paths.

- The only test that was attempting to test some of this code through mirrors (sic!)
has been disabled since January 2015.

After deletion all tests continue to pass meaning that nobody really relies on this
broken code in any way.

BUG=https://github.com/dart-lang/sdk/issues/28882
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/1c7cb7c5e911367aa3b172fe099483e32f8d5ed5

[Vyacheslav Egorov (Google), 2017-02-27 15:03:48]

vegorov@google.com changed reviewers:
+ johnmccutchan@google.com

[Vyacheslav Egorov (Google), 2017-02-27 15:03:49]

Hi John! Please take a look.

[Cutch, 2017-02-27 15:07:20]

Definitely old dead code.

lgtm!

[Vyacheslav Egorov (Google), 2017-02-27 15:08:19]

Description was changed from

==========
VM: remove service_object_patch.dart and all associated code.

This deletion has several reasons:

- This code is broken and refers to non-existant private parts of dart:io
(e.g. `_NativeSocket._sockets`, `_ProcessImpl._processes`,
`_RandomAccessFile._files`).

- This code is not reachable through the service protocol.
`_serviceObjectHandler` uses
`paths` to fetch the right handler from `_servicePathMap` but caller
`ServiceGetIOHandler`
always passes empty paths.

- The only test that was attempting to test some of this code through mirrors
(sic!)
has been disabled since January 2015.

After deletion all tests continue to pass meaning that nobody really relies on
this
broken code in any way.

BUG=https://github.com/dart-lang/sdk/issues/28882
==========

to

==========
VM: remove service_object_patch.dart and all associated code.

This deletion has several reasons:

- This code is broken and refers to non-existant private parts of dart:io
(e.g. `_NativeSocket._sockets`, `_ProcessImpl._processes`,
`_RandomAccessFile._files`).

- This code is not reachable through the service protocol.
`_serviceObjectHandler` uses
`paths` to fetch the right handler from `_servicePathMap` but caller
`ServiceGetIOHandler`
always passes empty paths.

- The only test that was attempting to test some of this code through mirrors
(sic!)
has been disabled since January 2015.

After deletion all tests continue to pass meaning that nobody really relies on
this
broken code in any way.

BUG=https://github.com/dart-lang/sdk/issues/28882
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1c7cb7c5e911367aa3b172fe099483e32f8d5ed5
==========

[Vyacheslav Egorov (Google), 2017-02-27 15:08:20]

Committed patchset #1 (id:1) manually as
1c7cb7c5e911367aa3b172fe099483e32f8d5ed5 (presubmit successful).