Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2715243005: Print user-friendly name when parsing invalid redirecting constructor. (Closed)

Created:
3 years, 9 months ago by Florian Schneider
Modified:
3 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Print user-friendly name when parsing invalid redirecting constructor. Addressing comments on https://codereview.chromium.org/2710363002/ R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/cf5a62efc5547f64aae4d44be2607d927886d984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/vm/parser.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
3 years, 9 months ago (2017-02-27 18:49:44 UTC) #2
hausner
lgtm
3 years, 9 months ago (2017-02-27 19:22:27 UTC) #3
Florian Schneider
3 years, 9 months ago (2017-02-27 20:20:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cf5a62efc5547f64aae4d44be2607d927886d984 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698