Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2363)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame. (Closed)
Patch Set: add unit test for remote frame transparency Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 84125df7bd71fc340acfb806624a14f9c8927378..ad2f40941cd8816c7a03a0ebab52b0a4f2c70fe3 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -290,12 +290,16 @@ class WEB_EXPORT WebViewImpl final
void setBaseBackgroundColorOverride(WebColor);
void clearBaseBackgroundColorOverride();
void setBackgroundColorOverride(WebColor);
+ void clearBackgroundColorOverride();
void setZoomFactorOverride(float);
void setCompositorDeviceScaleFactorOverride(float);
void setDeviceEmulationTransform(const TransformationMatrix&);
TransformationMatrix getDeviceEmulationTransformForTesting() const;
Color baseBackgroundColor() const;
+ bool backgroundColorOverrideEnabled() const {
+ return m_backgroundColorOverrideEnabled;
+ }
WebColor backgroundColorOverride() const { return m_backgroundColorOverride; }
Frame* focusedCoreFrame() const;
@@ -496,9 +500,6 @@ class WEB_EXPORT WebViewImpl final
FloatSize elasticOverscroll() const { return m_elasticOverscroll; }
- bool isTransparent() const;
- void setIsTransparent(bool value);
-
double lastFrameTimeMonotonic() const { return m_lastFrameTimeMonotonic; }
ChromeClientImpl& chromeClient() const { return *m_chromeClientImpl.get(); }
@@ -679,9 +680,6 @@ class WEB_EXPORT WebViewImpl final
Persistent<DevToolsEmulator> m_devToolsEmulator;
std::unique_ptr<PageOverlay> m_pageColorOverlay;
- // Whether the webview is rendering transparently.
- bool m_isTransparent;
-
// Whether the user can press tab to focus links.
bool m_tabsToLinks;
@@ -711,6 +709,7 @@ class WEB_EXPORT WebViewImpl final
WebColor m_baseBackgroundColor;
bool m_baseBackgroundColorOverrideEnabled;
WebColor m_baseBackgroundColorOverride;
+ bool m_backgroundColorOverrideEnabled;
WebColor m_backgroundColorOverride;
float m_zoomFactorOverride;

Powered by Google App Engine
This is Rietveld 408576698