third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp - Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp

Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame. (Closed)

Patch Set: add unit test for remote frame transparency Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameView.cpp ('K') | « third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h ('k') | third_party/WebKit/Source/web/DevToolsEmulator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp

diff --git a/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp b/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp

index d31e86f12875f955069334868f8e0bd978086e67..eae44d909f0666684d09acf69996f3826de611b6 100644

--- a/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp

+++ b/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp

@@ -92,11 +92,8 @@ void WebLayerTreeViewImplForTesting::setDeviceScaleFactor(

void WebLayerTreeViewImplForTesting::setBackgroundColor(WebColor color) {

m_layerTreeHost->set_background_color(color);

-void WebLayerTreeViewImplForTesting::setHasTransparentBackground(

- bool transparent) {

- m_layerTreeHost->set_has_transparent_background(transparent);

+ m_layerTreeHost->set_has_transparent_background(SkColorGetA(color) <

+ SK_AlphaOPAQUE);

}

void WebLayerTreeViewImplForTesting::setVisible(bool visible) {