third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame. (Closed)

Patch Set: add unit test for remote frame transparency Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index ecb7d462c1567369135d1db945f254f1d6c425fa..45980ee437058bb8b8373274cc479afdf2d9183b 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -270,7 +270,6 @@ void LocalFrame::setView(FrameView* view) {

void LocalFrame::createView(const IntSize& viewportSize,

const Color& backgroundColor,

- bool transparent,

ScrollbarMode horizontalScrollbarMode,

bool horizontalLock,

ScrollbarMode verticalScrollbarMode,

@@ -300,7 +299,7 @@ void LocalFrame::createView(const IntSize& viewportSize,

setView(frameView);

- frameView->updateBackgroundRecursively(backgroundColor, transparent);

+ frameView->updateBaseBackgroundColorRecursively(backgroundColor);

if (isLocalRoot)

frameView->setParentVisible(true);