Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame. (Closed)
Patch Set: add unit test for remote frame transparency Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index 5c414251a3bcf7ea3e3e9a35748f5708795a7d50..eed99366cee501408991c81894f4a0694309cff8 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -190,16 +190,12 @@ class CORE_EXPORT FrameView final
void clear();
- bool isTransparent() const;
- void setTransparent(bool isTransparent);
-
- // True if the FrameView is not transparent, and the base background color is
- // opaque.
+ // True if the FrameView's base background color is completely opaque.
bool hasOpaqueBackground() const;
Color baseBackgroundColor() const;
void setBaseBackgroundColor(const Color&);
- void updateBackgroundRecursively(const Color&, bool);
+ void updateBaseBackgroundColorRecursively(const Color&);
void adjustViewSize();
void adjustViewSizeAndLayout();
@@ -1084,7 +1080,6 @@ class CORE_EXPORT FrameView final
TaskRunnerTimer<FrameView> m_updatePluginsTimer;
bool m_firstLayout;
- bool m_isTransparent;
Color m_baseBackgroundColor;
IntSize m_lastViewportSize;
float m_lastZoomFactor;

Powered by Google App Engine
This is Rietveld 408576698