third_party/WebKit/Source/core/paint/ViewPainter.cpp - Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame.

Unified Diff: third_party/WebKit/Source/core/paint/ViewPainter.cpp

Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame. (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/ViewPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/ViewPainter.cpp b/third_party/WebKit/Source/core/paint/ViewPainter.cpp

index 1b2d2fea3c3b90437f8d95eea680874fb5955f33..6d53b15a80771a9bb20178c60991b71eff3c22d4 100644

--- a/third_party/WebKit/Source/core/paint/ViewPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/ViewPainter.cpp

@@ -86,7 +86,8 @@ void ViewPainter::paintBoxDecorationBackground(const PaintInfo& paintInfo) {

const Document& document = m_layoutView.document();

const FrameView& frameView = *m_layoutView.frameView();

bool isMainFrame = document.isInMainFrame();

- bool paintsBaseBackground = isMainFrame && !frameView.isTransparent();

+ bool paintsBaseBackground =

+ isMainFrame && (frameView.baseBackgroundColor().alpha() > 0);

chrishtr 2017/03/28 19:45:55 This doesn't look right. hasAlpha() instead? Is th

Eric Seckler 2017/03/29 10:50:18 hasAlpha() == alpha() < 255, i.e. is true iff not-

chrishtr 2017/03/29 15:36:41 Ah I see now. The old code was calling isTranspare

bool shouldClearCanvas =

paintsBaseBackground &&

(document.settings() &&