third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp - Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame. (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

index 655a092e4b9f40c5dd5a4012fee0c83c5badb6d0..ee8e8590cb097f72d0e62d86079da88615f8b28c 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

@@ -2235,7 +2235,7 @@ Response InspectorCSSAgent::getBackgroundColors(

Document& document = element->document();

bool isMainFrame = document.isInMainFrame();

bool foundOpaqueColor = false;

- if (isMainFrame && !view->isTransparent()) {

+ if (isMainFrame) {

// Start with the "default" page color (typically white).

Color baseBackgroundColor = view->baseBackgroundColor();

colors.push_back(view->baseBackgroundColor());