third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame. (Closed)

Patch Set: remove set/isTransparent from WebViewImpl and FrameView, use setBaseBackgroundColor instead Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index c806ccf5bb2817eaa64aadf0cb45cbf50f1595bb..05af0281a11ee6793a7ff664381e46ec867e3217 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -8116,8 +8116,8 @@ namespace {

class TestFullscreenWebLayerTreeView : public WebLayerTreeView {

public:

- void setHasTransparentBackground(bool value) override {

- hasTransparentBackground = value;

+ void setBackgroundColor(blink::WebColor color) override {

+ hasTransparentBackground = SkColorGetA(color) < SK_AlphaOPAQUE;

}

bool hasTransparentBackground = false;

};