third_party/WebKit/Source/web/InspectorOverlay.cpp - Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame. (Closed)

Patch Set: remove set/isTransparent from WebViewImpl and FrameView, use setBaseBackgroundColor instead Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/InspectorOverlay.cpp

diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp

index 370cfb8228b45d76ee4066f0dbc0649d999ee9ba..9c0888324d347ef7cfa762d86ee837f7f6f51b2f 100644

--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp

+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp

@@ -51,6 +51,7 @@

#include "core/page/ChromeClient.h"

#include "core/page/Page.h"

#include "platform/ScriptForbiddenScope.h"

+#include "platform/graphics/Color.h"

#include "platform/graphics/GraphicsContext.h"

#include "platform/graphics/paint/CullRect.h"

#include "public/platform/Platform.h"

@@ -551,7 +552,7 @@ Page* InspectorOverlay::overlayPage() {

frame->init();

FrameLoader& loader = frame->loader();

frame->view()->setCanHaveScrollbars(false);

- frame->view()->setTransparent(true);

+ frame->view()->setBaseBackgroundColor(Color::transparent);

const WebData& overlayPageHTMLResource =

Platform::current()->loadResource("InspectorOverlayPage.html");