Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame. (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 8098 matching lines...) Expand 10 before | Expand all | Expand 10 after
8109 EXPECT_EQ(200, layoutViewItem.logicalWidth().floor()); 8109 EXPECT_EQ(200, layoutViewItem.logicalWidth().floor());
8110 EXPECT_EQ(400, layoutViewItem.logicalHeight().floor()); 8110 EXPECT_EQ(400, layoutViewItem.logicalHeight().floor());
8111 EXPECT_FLOAT_EQ(0.5, webViewImpl->minimumPageScaleFactor()); 8111 EXPECT_FLOAT_EQ(0.5, webViewImpl->minimumPageScaleFactor());
8112 EXPECT_FLOAT_EQ(5.0, webViewImpl->maximumPageScaleFactor()); 8112 EXPECT_FLOAT_EQ(5.0, webViewImpl->maximumPageScaleFactor());
8113 } 8113 }
8114 8114
8115 namespace { 8115 namespace {
8116 8116
8117 class TestFullscreenWebLayerTreeView : public WebLayerTreeView { 8117 class TestFullscreenWebLayerTreeView : public WebLayerTreeView {
8118 public: 8118 public:
8119 void setHasTransparentBackground(bool value) override { 8119 void setBackgroundColor(blink::WebColor color) override {
8120 hasTransparentBackground = value; 8120 hasTransparentBackground = SkColorGetA(color) < SK_AlphaOPAQUE;
8121 } 8121 }
8122 bool hasTransparentBackground = false; 8122 bool hasTransparentBackground = false;
8123 }; 8123 };
8124 8124
8125 class TestFullscreenWebViewClient : public FrameTestHelpers::TestWebViewClient { 8125 class TestFullscreenWebViewClient : public FrameTestHelpers::TestWebViewClient {
8126 public: 8126 public:
8127 WebLayerTreeView* initializeLayerTreeView() override { 8127 WebLayerTreeView* initializeLayerTreeView() override {
8128 return &testFullscreenLayerTreeView; 8128 return &testFullscreenLayerTreeView;
8129 } 8129 }
8130 TestFullscreenWebLayerTreeView testFullscreenLayerTreeView; 8130 TestFullscreenWebLayerTreeView testFullscreenLayerTreeView;
(...skipping 3298 matching lines...) Expand 10 before | Expand all | Expand 10 after
11429 EXPECT_FALSE(testSelectAll("<textarea></textarea>")); 11429 EXPECT_FALSE(testSelectAll("<textarea></textarea>"));
11430 EXPECT_TRUE(testSelectAll("<textarea>nonempty</textarea>")); 11430 EXPECT_TRUE(testSelectAll("<textarea>nonempty</textarea>"));
11431 EXPECT_FALSE(testSelectAll("<input>")); 11431 EXPECT_FALSE(testSelectAll("<input>"));
11432 EXPECT_TRUE(testSelectAll("<input value='nonempty'>")); 11432 EXPECT_TRUE(testSelectAll("<input value='nonempty'>"));
11433 // TODO(amaralp): Empty contenteditable should not have select all enabled. 11433 // TODO(amaralp): Empty contenteditable should not have select all enabled.
11434 EXPECT_TRUE(testSelectAll("<div contenteditable></div>")); 11434 EXPECT_TRUE(testSelectAll("<div contenteditable></div>"));
11435 EXPECT_TRUE(testSelectAll("<div contenteditable>nonempty</div>")); 11435 EXPECT_TRUE(testSelectAll("<div contenteditable>nonempty</div>"));
11436 } 11436 }
11437 11437
11438 } // namespace blink 11438 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698