[blink] Support (semi-)transparent background colors in WebView/Frame.

third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 148 matching lines @@
 #include "core/timing/DOMWindowPerformance.h"
 #include "core/timing/Performance.h"
 #include "modules/app_banner/AppBannerController.h"
 #include "modules/installation/InstallationServiceImpl.h"
 #include "modules/screen_orientation/ScreenOrientationControllerImpl.h"
 #include "platform/ScriptForbiddenScope.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/WebFrameScheduler.h"
 #include "platform/clipboard/ClipboardUtilities.h"
 #include "platform/fonts/FontCache.h"
+#include "platform/graphics/Color.h"
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/graphics/GraphicsLayerClient.h"
 #include "platform/graphics/paint/ClipRecorder.h"
 #include "platform/graphics/paint/DisplayItemCacheSkipper.h"
 #include "platform/graphics/paint/DrawingRecorder.h"
 #include "platform/graphics/paint/PaintRecordBuilder.h"
 #include "platform/graphics/skia/SkiaUtils.h"
 #include "platform/heap/Handle.h"
 #include "platform/instrumentation/tracing/TraceEvent.h"
 #include "platform/loader/fetch/ResourceFetcher.h"
@@ skipping 1529 matching lines @@
   WebViewImpl* webView = viewImpl();
 
   // Check if we're shutting down.
   if (!webView->page())
     return;
 
   bool isMainFrame = !parent();
   IntSize initialSize = (isMainFrame || !frameWidget())
                             ? webView->mainFrameSize()
                             : (IntSize)frameWidget()->size();
-  bool isTransparent = !isMainFrame && parent()->isWebRemoteFrame()
-                           ? true
-                           : webView->isTransparent();
+  Color baseBackgroundColor = webView->baseBackgroundColor();
+  if (!isMainFrame && parent()->isWebRemoteFrame())
+    baseBackgroundColor = Color::transparent;

[chrishtr, 2017/03/28 19:45:56]

I think the old code just used a conditional here to detect alpha and
pass it along, but still respected the non-alpha parts of
webView->baseBackgroundColor(). Also, tested?

[Eric Seckler, 2017/03/29 10:50:18]

My understanding is that the old code was setting FrameView::isTransparent to
true, which resulted in !paintsBackgroundColor in ViewPainter, thus no
background color would have been painted for the FrameView. Setting a completely
transparent baseBackgroundColor should have the same effect now.

Based on the fact that I forgot to actually use the local variable in createView
below, I think it's a safe bet that this isn't tested :P

lfg@, do you have a suggestion of how to test this, since you added this
condition in https://codereview.chromium.org/1565893004 ? :)

[lfg, 2017/03/29 15:19:43]

Yes, that's my understanding as well.
Yes, ideally, this should be a pixel test where we can check that the background
is being drawn properly. At the time I added that, there was no way to do pixel
tests on out-of-process iframes (which is what we are checking here -- remote
parent), I know that lukasza@ (OOO) did a lot of work around this area (see bug
587175), but I'm not sure if it's fully functional yet.

Maybe alternatively, we could write a unit test in WebFrameTest that just
creates a LocalFrame with a RemoteFrame parent, and asserts that the background
color is transparent. It's not as good as a layouttest, but at least gives us
some test coverage (you can file a bug and assign it to me, no need to do it in
this CL).

[Eric Seckler, 2017/03/30 10:46:38]

Added a unit test and filed https://crbug.com/706782 for the layout test.

 
-  frame()->createView(initialSize, webView->baseBackgroundColor(),
-                      isTransparent);
+  frame()->createView(initialSize, webView->baseBackgroundColor());
   if (isMainFrame) {
     frame()->view()->setInitialViewportSize(
         webView->pageScaleConstraintsSet().initialViewportSize());
   }
   if (webView->shouldAutoResize() && frame()->isLocalRoot())
     frame()->view()->enableAutoSizeMode(webView->minAutoSize(),
                                         webView->maxAutoSize());
 
   frame()->view()->setInputEventsTransformForEmulation(
       m_inputEventsOffsetForEmulation, m_inputEventsScaleFactorForEmulation);
@@ skipping 771 matching lines @@
         createMarkup(startPosition, endPosition, AnnotateForInterchange,
                      ConvertBlocksToInlines::NotConvert, ResolveNonLocalURLs);
   } else {
     clipHtml =
         createMarkup(endPosition, startPosition, AnnotateForInterchange,
                      ConvertBlocksToInlines::NotConvert, ResolveNonLocalURLs);
   }
 }
 
 }  // namespace blink