[blink] Support (semi-)transparent background colors in WebView/Frame.

third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 148 matching lines @@
 #include "core/timing/DOMWindowPerformance.h"
 #include "core/timing/Performance.h"
 #include "modules/app_banner/AppBannerController.h"
 #include "modules/installation/InstallationServiceImpl.h"
 #include "modules/screen_orientation/ScreenOrientationControllerImpl.h"
 #include "platform/ScriptForbiddenScope.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/WebFrameScheduler.h"
 #include "platform/clipboard/ClipboardUtilities.h"
 #include "platform/fonts/FontCache.h"
+#include "platform/graphics/Color.h"
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/graphics/GraphicsLayerClient.h"
 #include "platform/graphics/paint/ClipRecorder.h"
 #include "platform/graphics/paint/DisplayItemCacheSkipper.h"
 #include "platform/graphics/paint/DrawingRecorder.h"
 #include "platform/graphics/paint/PaintRecordBuilder.h"
 #include "platform/graphics/skia/SkiaUtils.h"
 #include "platform/heap/Handle.h"
 #include "platform/instrumentation/tracing/TraceEvent.h"
 #include "platform/loader/fetch/ResourceFetcher.h"
@@ skipping 1540 matching lines @@
   WebViewImpl* webView = viewImpl();
 
   // Check if we're shutting down.
   if (!webView->page())
     return;
 
   bool isMainFrame = !parent();
   IntSize initialSize = (isMainFrame || !frameWidget())
                             ? webView->mainFrameSize()
                             : (IntSize)frameWidget()->size();
-  bool isTransparent = !isMainFrame && parent()->isWebRemoteFrame()
-                           ? true
-                           : webView->isTransparent();
+  Color baseBackgroundColor = webView->baseBackgroundColor();
+  if (!isMainFrame && parent()->isWebRemoteFrame()) {

[lfg, 2017/03/23 16:05:21]

nit: no need for {}

[Eric Seckler, 2017/03/23 16:34:49]

Done.

+    baseBackgroundColor = Color::transparent;
+  }
 
-  frame()->createView(initialSize, webView->baseBackgroundColor(),
-                      isTransparent);
+  frame()->createView(initialSize, webView->baseBackgroundColor());
   if (isMainFrame) {
     frame()->view()->setInitialViewportSize(
         webView->pageScaleConstraintsSet().initialViewportSize());
   }
   if (webView->shouldAutoResize() && frame()->isLocalRoot())
     frame()->view()->enableAutoSizeMode(webView->minAutoSize(),
                                         webView->maxAutoSize());
 
   frame()->view()->setInputEventsTransformForEmulation(
       m_inputEventsOffsetForEmulation, m_inputEventsScaleFactorForEmulation);
@@ skipping 771 matching lines @@
         createMarkup(startPosition, endPosition, AnnotateForInterchange,
                      ConvertBlocksToInlines::NotConvert, ResolveNonLocalURLs);
   } else {
     clipHtml =
         createMarkup(endPosition, startPosition, AnnotateForInterchange,
                      ConvertBlocksToInlines::NotConvert, ResolveNonLocalURLs);
   }
 }
 
 }  // namespace blink