Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 271523002: Add the plumbing to enable DRP (Closed)

Created:
6 years, 7 months ago by sgurun-gerrit only
Modified:
6 years, 7 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Add the plumbing to enable DRP BUG=b/12492817, 363403 Add the internal Aw API to enable/disable DRP. NOTRY=true notry due to irrelevant failures in windows rel tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269498

Patch Set 1 #

Total comments: 2

Patch Set 2 : address code review nits #

Patch Set 3 : rebase #

Patch Set 4 : removed test log #

Patch Set 5 : cache the initial value #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M android_webview/browser/aw_browser_context.h View 1 2 3 4 2 chunks +4 lines, -0 lines 1 comment Download
M android_webview/browser/aw_browser_context.cc View 1 2 3 4 3 chunks +21 lines, -3 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M android_webview/native/aw_contents_statics.cc View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
sgurun-gerrit only
PTAL, thanks, https://codereview.chromium.org/271523002/diff/1/android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java File android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java (right): https://codereview.chromium.org/271523002/diff/1/android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java#newcode52 android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java:52: ThreadUtils.assertOnUiThread(); will add the same check to ...
6 years, 7 months ago (2014-05-06 23:29:24 UTC) #1
boliu
lgtm https://codereview.chromium.org/271523002/diff/1/android_webview/native/aw_contents_statics.cc File android_webview/native/aw_contents_statics.cc (right): https://codereview.chromium.org/271523002/diff/1/android_webview/native/aw_contents_statics.cc#newcode52 android_webview/native/aw_contents_statics.cc:52: if (context == NULL) return; return on new ...
6 years, 7 months ago (2014-05-06 23:38:04 UTC) #2
boliu
https://codereview.chromium.org/271523002/diff/80001/android_webview/browser/aw_browser_context.h File android_webview/browser/aw_browser_context.h (right): https://codereview.chromium.org/271523002/diff/80001/android_webview/browser/aw_browser_context.h#newcode67 android_webview/browser/aw_browser_context.h:67: static void SetDataReductionProxyEnabled(bool enabled); AwBrowserContext is effectively global already. ...
6 years, 7 months ago (2014-05-07 23:30:09 UTC) #3
sgurun-gerrit only
On 2014/05/07 23:30:09, boliu wrote: > https://codereview.chromium.org/271523002/diff/80001/android_webview/browser/aw_browser_context.h > File android_webview/browser/aw_browser_context.h (right): > > https://codereview.chromium.org/271523002/diff/80001/android_webview/browser/aw_browser_context.h#newcode67 > ...
6 years, 7 months ago (2014-05-08 01:53:45 UTC) #4
sgurun-gerrit only
The CQ bit was checked by sgurun@chromium.org
6 years, 7 months ago (2014-05-08 01:53:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sgurun@chromium.org/271523002/80001
6 years, 7 months ago (2014-05-08 01:54:58 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 06:57:34 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 18:05:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/13499)
6 years, 7 months ago (2014-05-08 18:05:26 UTC) #9
boliu
Time for NOTRY
6 years, 7 months ago (2014-05-08 18:05:49 UTC) #10
sgurun-gerrit only
On 2014/05/08 18:05:49, boliu wrote: > Time for NOTRY yeah once tree opens
6 years, 7 months ago (2014-05-08 18:11:36 UTC) #11
boliu
On 2014/05/08 18:11:36, sgurun wrote: > On 2014/05/08 18:05:49, boliu wrote: > > Time for ...
6 years, 7 months ago (2014-05-08 18:12:12 UTC) #12
sgurun-gerrit only
The CQ bit was checked by sgurun@chromium.org
6 years, 7 months ago (2014-05-08 18:42:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sgurun@chromium.org/271523002/80001
6 years, 7 months ago (2014-05-08 18:47:28 UTC) #14
sgurun-gerrit only
The CQ bit was unchecked by sgurun@chromium.org
6 years, 7 months ago (2014-05-09 01:23:50 UTC) #15
sgurun-gerrit only
The CQ bit was checked by sgurun@chromium.org
6 years, 7 months ago (2014-05-09 01:23:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sgurun@chromium.org/271523002/80001
6 years, 7 months ago (2014-05-09 01:25:32 UTC) #17
sgurun-gerrit only
The CQ bit was unchecked by sgurun@chromium.org
6 years, 7 months ago (2014-05-09 02:13:57 UTC) #18
sgurun-gerrit only
The CQ bit was checked by sgurun@chromium.org
6 years, 7 months ago (2014-05-09 02:14:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sgurun@chromium.org/271523002/80001
6 years, 7 months ago (2014-05-09 02:18:32 UTC) #20
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 02:56:48 UTC) #21
Message was sent while issue was closed. 
Change committed as 269498

Powered by Google App Engine
This is Rietveld 408576698