Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2715223002: Use the correct URI for diagnostics during outline construction. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use the correct URI for diagnostics during outline construction. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/34be60b6639eb5f8113715ba2c919f9c46348399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-02-27 08:49:43 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-02-27 10:33:42 UTC) #3
ahe
3 years, 9 months ago (2017-02-27 12:08:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
34be60b6639eb5f8113715ba2c919f9c46348399 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698