Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Issue 2715213009: Re-enable FocusBeforeNavigation test. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 646 matching lines...) Expand 10 before | Expand all | Expand 10 after
657 // Wait for page to receive (successful) mouse unlock response. 657 // Wait for page to receive (successful) mouse unlock response.
658 ASSERT_TRUE(unlocked_listener.WaitUntilSatisfied()); 658 ASSERT_TRUE(unlocked_listener.WaitUntilSatisfied());
659 } 659 }
660 660
661 #endif // defined(OS_LINUX) 661 #endif // defined(OS_LINUX)
662 662
663 // Tests that if a <webview> is focused before navigation then the guest starts 663 // Tests that if a <webview> is focused before navigation then the guest starts
664 // off focused. 664 // off focused.
665 IN_PROC_BROWSER_TEST_P(WebViewFocusInteractiveTest, 665 IN_PROC_BROWSER_TEST_P(WebViewFocusInteractiveTest,
666 Focus_FocusBeforeNavigation) { 666 Focus_FocusBeforeNavigation) {
667 // TODO(avallee): Determine if test is relevant with OOPIF or fix the bug.
668 // http://crbug.com/672947
669 if (GetParam())
670 return;
671 TestHelper("testFocusBeforeNavigation", "web_view/focus", NO_TEST_SERVER); 667 TestHelper("testFocusBeforeNavigation", "web_view/focus", NO_TEST_SERVER);
672 } 668 }
673 669
674 // Tests that setting focus on the <webview> sets focus on the guest. 670 // Tests that setting focus on the <webview> sets focus on the guest.
675 IN_PROC_BROWSER_TEST_P(WebViewFocusInteractiveTest, Focus_FocusEvent) { 671 IN_PROC_BROWSER_TEST_P(WebViewFocusInteractiveTest, Focus_FocusEvent) {
676 TestHelper("testFocusEvent", "web_view/focus", NO_TEST_SERVER); 672 TestHelper("testFocusEvent", "web_view/focus", NO_TEST_SERVER);
677 } 673 }
678 674
679 // Flaky on Mac and Linux - https://crbug.com/707648 675 // Flaky on Mac and Linux - https://crbug.com/707648
680 #if defined(OS_MACOSX) || defined(OS_LINUX) 676 #if defined(OS_MACOSX) || defined(OS_LINUX)
(...skipping 909 matching lines...) Expand 10 before | Expand all | Expand 10 after
1590 // Get the input value from the guest. 1586 // Get the input value from the guest.
1591 value.clear(); 1587 value.clear();
1592 ASSERT_TRUE(ExecuteScriptAndExtractString(guest_web_contents, 1588 ASSERT_TRUE(ExecuteScriptAndExtractString(guest_web_contents,
1593 "window.domAutomationController." 1589 "window.domAutomationController."
1594 "send(document.querySelector('" 1590 "send(document.querySelector('"
1595 "input').value)", 1591 "input').value)",
1596 &value)); 1592 &value));
1597 EXPECT_EQ("A B C D", value); 1593 EXPECT_EQ("A B C D", value);
1598 } 1594 }
1599 #endif // OS_MACOSX 1595 #endif // OS_MACOSX
OLDNEW
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698