Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Unified Diff: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Issue 2715213005: [Payments] Add the pay button, and control its enabled state (Closed)
Patch Set: addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
index dfcf2a696a1f031781b80711c4e31c99344e6cf4..aaa2a61d92c4277119af947f899b5edf6280640e 100644
--- a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
+++ b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
@@ -23,7 +23,6 @@
#include "components/autofill/core/browser/credit_card.h"
#include "components/autofill/core/browser/field_types.h"
#include "components/autofill/core/browser/personal_data_manager.h"
-#include "components/payments/content/payment_request.h"
#include "components/payments/core/currency_formatter.h"
#include "components/strings/grit/components_strings.h"
#include "content/public/browser/web_contents.h"
@@ -32,7 +31,6 @@
#include "ui/gfx/font.h"
#include "ui/gfx/paint_vector_icon.h"
#include "ui/gfx/range/range.h"
-#include "ui/views/controls/button/label_button.h"
#include "ui/views/controls/button/md_text_button.h"
#include "ui/views/controls/image_view.h"
#include "ui/views/controls/label.h"
@@ -54,6 +52,7 @@ enum class PaymentSheetViewControllerTags {
SHOW_SHIPPING_BUTTON,
SHOW_PAYMENT_METHOD_BUTTON,
SHOW_CONTACT_INFO_BUTTON,
+ PAY_BUTTON
};
int ComputeWidestNameColumnViewWidth() {
@@ -167,7 +166,10 @@ PaymentSheetViewController::PaymentSheetViewController(
PaymentRequest* request,
PaymentRequestDialogView* dialog)
: PaymentRequestSheetController(request, dialog),
- widest_name_column_view_width_(ComputeWidestNameColumnViewWidth()) {}
+ pay_button_(nullptr),
+ widest_name_column_view_width_(ComputeWidestNameColumnViewWidth()) {
+ request->AddObserver(this);
+}
PaymentSheetViewController::~PaymentSheetViewController() {}
@@ -197,6 +199,22 @@ std::unique_ptr<views::View> PaymentSheetViewController::CreateView() {
std::move(content_view));
}
+std::unique_ptr<views::Button>
+PaymentSheetViewController::CreatePrimaryButton() {
+ std::unique_ptr<views::Button> button(
+ views::MdTextButton::CreateSecondaryUiBlueButton(
+ this, l10n_util::GetStringUTF16(IDS_PAYMENTS_PAY_BUTTON)));
+ button->set_tag(static_cast<int>(PaymentRequestCommonTags::PAY_BUTTON_TAG));
+ button->set_id(static_cast<int>(DialogViewID::PAYMENT_SHEET_PAY_BUTTON));
+ pay_button_ = button.get();
+ UpdatePayButtonState(request()->is_ready_to_pay());
+ return button;
+}
+
+void PaymentSheetViewController::OnSelectedInformationChanged() {
+ UpdatePayButtonState(request()->is_ready_to_pay());
+}
+
void PaymentSheetViewController::ButtonPressed(
views::Button* sender, const ui::Event& event) {
switch (sender->tag()) {
@@ -225,6 +243,10 @@ void PaymentSheetViewController::ButtonPressed(
}
}
+void PaymentSheetViewController::UpdatePayButtonState(bool enabled) {
+ pay_button_->SetEnabled(enabled);
+}
+
std::unique_ptr<views::View>
PaymentSheetViewController::CreateOrderSummarySectionContent() {
CurrencyFormatter* formatter = request()->GetOrCreateCurrencyFormatter(

Powered by Google App Engine
This is Rietveld 408576698