Chromium Code Reviews
DescriptionRevert of Implement complete lifecycle transition for IdleSpellCheckCallback (patchset #7 id:120001 of https://codereview.chromium.org/2701983002/ )
Reason for revert:
It looks like this causes compile errors (e.g. https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder&number=62075)
Original issue's description:
> Implement complete lifecycle transition for IdleSpellCheckCallback
>
> This patch implements complete lifecycle state transition for
> IdleSpellCheckCallback. With this patch, idle spell check callback
> will be invoked at correct timings. The only thing remaining is to
> fill in the member functions which actually perform checking when
> the callback is invoked.
>
> BUG=517298
> TEST=webkit_unit_tests --gtest_filter=IdleSpellCheckCallbackTest.*
>
> Review-Url: https://codereview.chromium.org/2701983002
> Cr-Commit-Position: refs/heads/master@{#453159}
> Committed: https://chromium.googlesource.com/chromium/src/+/234937696e399887e0acef2ad037c35febca001c
TBR=tkent@chromium.org,yosin@chromium.org,xiaochengh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=517298
Patch Set 1 #Messages
Total messages: 8 (3 generated)
|