Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2715193002: Revert of Implement complete lifecycle transition for IdleSpellCheckCallback (Closed)

Created:
3 years, 9 months ago by hajimehoshi
Modified:
3 years, 9 months ago
Reviewers:
tkent, yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement complete lifecycle transition for IdleSpellCheckCallback (patchset #7 id:120001 of https://codereview.chromium.org/2701983002/ ) Reason for revert: It looks like this causes compile errors (e.g. https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder&number=62075) Original issue's description: > Implement complete lifecycle transition for IdleSpellCheckCallback > > This patch implements complete lifecycle state transition for > IdleSpellCheckCallback. With this patch, idle spell check callback > will be invoked at correct timings. The only thing remaining is to > fill in the member functions which actually perform checking when > the callback is invoked. > > BUG=517298 > TEST=webkit_unit_tests --gtest_filter=IdleSpellCheckCallbackTest.* > > Review-Url: https://codereview.chromium.org/2701983002 > Cr-Commit-Position: refs/heads/master@{#453159} > Committed: https://chromium.googlesource.com/chromium/src/+/234937696e399887e0acef2ad037c35febca001c TBR=tkent@chromium.org,yosin@chromium.org,xiaochengh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517298

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
hajimehoshi
Created Revert of Implement complete lifecycle transition for IdleSpellCheckCallback
3 years, 9 months ago (2017-02-27 05:56:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715193002/1
3 years, 9 months ago (2017-02-27 05:56:43 UTC) #3
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/editing/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-02-27 05:58:12 UTC) #5
Xiaocheng
Already reverted as 453161
3 years, 9 months ago (2017-02-27 05:59:21 UTC) #6
hajimehoshi
3 years, 9 months ago (2017-02-27 06:00:43 UTC) #7
Thanks

Powered by Google App Engine
This is Rietveld 408576698