Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: services/image_decoder/public/cpp/decode.h

Issue 2715153006: Set desired_image_size when decoding images for NTP Tile icons. (Closed)
Patch Set: comment formatting Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/image_decoder/image_decoder_impl_unittest.cc ('k') | services/image_decoder/public/cpp/decode.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/image_decoder/public/cpp/decode.h
diff --git a/services/image_decoder/public/cpp/decode.h b/services/image_decoder/public/cpp/decode.h
index 399617267d777acd1f053eac6bbed240d6d63bb3..ea0fa2e848ff7f23132746dc1afc13cbe195349f 100644
--- a/services/image_decoder/public/cpp/decode.h
+++ b/services/image_decoder/public/cpp/decode.h
@@ -11,6 +11,10 @@
#include "services/image_decoder/public/interfaces/image_decoder.mojom.h"
+namespace gfx {
+class Size;
+}
+
namespace service_manager {
class Connector;
}
@@ -19,15 +23,21 @@ namespace image_decoder {
const uint64_t kDefaultMaxSizeInBytes = 128 * 1024 * 1024;
-// Helper function to decode an image via the image_decoder service. Upon
-// completion, |callback| is invoked on the calling thread TaskRunner with an
-// SkBitmap argument. The SkBitmap will be null on failure and non-null on
+// Helper function to decode an image via the image_decoder service. For images
+// with multiple frames (e.g. ico files), a frame with a size as close as
+// possible to |desired_image_frame_size| is chosen (tries to take one in larger
+// size if there's no precise match). Passing gfx::Size() as
+// |desired_image_frame_size| is also supported and will result in chosing the
+// smallest available size.
+// Upon completion, |callback| is invoked on the calling thread TaskRunner with
+// an SkBitmap argument. The SkBitmap will be null on failure and non-null on
// success.
void Decode(service_manager::Connector* connector,
const std::vector<uint8_t>& encoded_bytes,
mojom::ImageCodec codec,
bool shrink_to_fit,
uint64_t max_size_in_bytes,
+ const gfx::Size& desired_image_frame_size,
const mojom::ImageDecoder::DecodeImageCallback& callback);
} // namespace image_decoder
« no previous file with comments | « services/image_decoder/image_decoder_impl_unittest.cc ('k') | services/image_decoder/public/cpp/decode.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698