Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: components/ntp_tiles/icon_cacher_impl_unittest.cc

Issue 2715153006: Set desired_image_size when decoding images for NTP Tile icons. (Closed)
Patch Set: comment formatting Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_tiles/icon_cacher_impl.cc ('k') | components/suggestions/image_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_tiles/icon_cacher_impl_unittest.cc
diff --git a/components/ntp_tiles/icon_cacher_impl_unittest.cc b/components/ntp_tiles/icon_cacher_impl_unittest.cc
index 12dcf815e12018d121d9299f7b9830ad40b23bfb..eb7ff451807d32f4c448c958ce9e9fb1fb448879 100644
--- a/components/ntp_tiles/icon_cacher_impl_unittest.cc
+++ b/components/ntp_tiles/icon_cacher_impl_unittest.cc
@@ -39,6 +39,7 @@ class MockImageFetcher : public image_fetcher::ImageFetcher {
const GURL& image_url,
base::Callback<void(const std::string& id,
const gfx::Image& image)> callback));
+ MOCK_METHOD1(SetDesiredImageFrameSize, void(const gfx::Size&));
};
class IconCacherTest : public ::testing::Test {
@@ -118,6 +119,7 @@ TEST_F(IconCacherTest, LargeCached) {
EXPECT_CALL(*image_fetcher_,
SetDataUseServiceName(
data_use_measurement::DataUseUserData::NTP_TILES));
+ EXPECT_CALL(*image_fetcher_, SetDesiredImageFrameSize(gfx::Size(128, 128)));
EXPECT_CALL(done, Call(false)).WillOnce(Quit(&loop));
}
PreloadIcon(site_.url, site_.large_icon_url, favicon_base::TOUCH_ICON, 128,
@@ -138,6 +140,7 @@ TEST_F(IconCacherTest, LargeNotCachedAndFetchSucceeded) {
EXPECT_CALL(*image_fetcher_,
SetDataUseServiceName(
data_use_measurement::DataUseUserData::NTP_TILES));
+ EXPECT_CALL(*image_fetcher_, SetDesiredImageFrameSize(gfx::Size(128, 128)));
EXPECT_CALL(*image_fetcher_,
StartOrQueueNetworkRequest(_, site_.large_icon_url, _))
.WillOnce(PassFetch(128, 128));
@@ -161,6 +164,7 @@ TEST_F(IconCacherTest, SmallNotCachedAndFetchSucceeded) {
EXPECT_CALL(*image_fetcher_,
SetDataUseServiceName(
data_use_measurement::DataUseUserData::NTP_TILES));
+ EXPECT_CALL(*image_fetcher_, SetDesiredImageFrameSize(gfx::Size(128, 128)));
EXPECT_CALL(*image_fetcher_,
StartOrQueueNetworkRequest(_, site_.favicon_url, _))
.WillOnce(PassFetch(128, 128));
@@ -182,6 +186,7 @@ TEST_F(IconCacherTest, LargeNotCachedAndFetchFailed) {
EXPECT_CALL(*image_fetcher_,
SetDataUseServiceName(
data_use_measurement::DataUseUserData::NTP_TILES));
+ EXPECT_CALL(*image_fetcher_, SetDesiredImageFrameSize(gfx::Size(128, 128)));
EXPECT_CALL(*image_fetcher_,
StartOrQueueNetworkRequest(_, site_.large_icon_url, _))
.WillOnce(FailFetch());
« no previous file with comments | « components/ntp_tiles/icon_cacher_impl.cc ('k') | components/suggestions/image_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698