Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: components/image_fetcher/image_decoder.h

Issue 2715153006: Set desired_image_size when decoding images for NTP Tile icons. (Closed)
Patch Set: ran git cl format as suggested Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/image_fetcher/image_decoder.h
diff --git a/components/image_fetcher/image_decoder.h b/components/image_fetcher/image_decoder.h
index 904830cb0cb42c43b5a6bf0b02e5903f0ab98881..1eb715726072acbaf6dd460741105e40ca44ff42 100644
--- a/components/image_fetcher/image_decoder.h
+++ b/components/image_fetcher/image_decoder.h
@@ -12,6 +12,7 @@
namespace gfx {
class Image;
+class Size;
} // namespace gfx
namespace image_fetcher {
@@ -27,7 +28,11 @@ class ImageDecoder {
// Decodes the passed |image_data| and runs the given callback. The callback
// is run even if decoding the image fails. In case an error occured during
// decoding the image an empty image is passed to the callback.
+ // For images with multiple frames (e.g. ico files), a frame with a size as
+ // close as possible to |desired_image_frame_size| is chosen (tries to take
+ // one in larger size if there's no precise match).
virtual void DecodeImage(const std::string& image_data,
+ const gfx::Size& desired_image_frame_size,
const ImageDecodedCallback& callback) = 0;
private:

Powered by Google App Engine
This is Rietveld 408576698