Set desired_image_size when decoding images for NTP Tile icons.

chrome/browser/search/suggestions/image_decoder_impl.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SEARCH_SUGGESTIONS_IMAGE_DECODER_IMPL_H_
 #define CHROME_BROWSER_SEARCH_SUGGESTIONS_IMAGE_DECODER_IMPL_H_
 
 #include <memory>
 #include <vector>
 
 #include "chrome/browser/image_decoder.h"
 #include "components/image_fetcher/image_decoder.h"
 
 namespace suggestions {
 
 // image_fetcher::ImageDecoder Implementation.
 class ImageDecoderImpl : public image_fetcher::ImageDecoder {
  public:
   ImageDecoderImpl();
   ~ImageDecoderImpl() override;
 
   void DecodeImage(
       const std::string& image_data,
+      const gfx::Size& desired_image_frame_size,
       const image_fetcher::ImageDecodedCallback& callback) override;

[Marc Treib, 2017/03/01 09:17:26]

Hm, one high-level comment: This returns a gfx::Image, which has support for
multiple sizes. If that's possible, it might be nicer (API-wise) to simply
decode all of them. WDYT?

[tschumann, 2017/03/01 09:37:43]

I totally agree -- just that's how the whole image decoding stack works :-)

If there's a place where we need multiple versions of the image, we should
follow up. Right now, I don't have a clear use case. Plus, that's a much larger
change. 

Let's fix the concrete issue here, and then get the larger discussion started.

[Marc Treib, 2017/03/01 09:41:56]

I think in terms of API, it would actually be a smaller change: no need to pass
the gfx::Size around everywhere. Just on the lowest level, we'd decode all
available frames.

But probably, an API that allows to request a specific size is useful anyway, so
I'm okay with this too.

[tschumann, 2017/03/01 11:36:36]

I agree. I'm mostly concerned about changing semantics though and regressions --
given how many parties use this API. If we have a strong use case, I'm
absolutely willing to push that idea forward (just as a separate effort).

 
  private:
   class DecodeImageRequest;
 
   // Removes the passed image decode |request| from the internal request queue.
   void RemoveDecodeImageRequest(DecodeImageRequest* request);
 
   // All active image decoding requests.
   std::vector<std::unique_ptr<DecodeImageRequest>> decode_image_requests_;
 
   DISALLOW_COPY_AND_ASSIGN(ImageDecoderImpl);
 };
 
 }  // namespace suggestions
 
 #endif  // CHROME_BROWSER_SEARCH_SUGGESTIONS_IMAGE_DECODER_IMPL_H_