Devirtualize ExceptionState's helper throwing methods.

third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #include "bindings/core/v8/ExceptionState.h"
 
 #include "bindings/core/v8/ExceptionMessages.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/V8ThrowException.h"
 #include "core/dom/ExceptionCode.h"
 
 namespace blink {
 
+bool ExceptionState::shouldThrow() const {
+  return true;
+}
+
 void ExceptionState::throwDOMException(ExceptionCode ec, const char* message) {
   throwDOMException(ec, String(message));
 }
 
 void ExceptionState::throwRangeError(const char* message) {
   throwRangeError(String(message));
 }
 
 void ExceptionState::throwSecurityError(const char* sanitizedMessage,
                                         const char* unsanitizedMessage) {
   throwSecurityError(String(sanitizedMessage), String(unsanitizedMessage));
 }
 
 void ExceptionState::throwTypeError(const char* message) {
   throwTypeError(String(message));
 }
 
 void ExceptionState::throwDOMException(ExceptionCode ec,
                                        const String& message) {
   // SecurityError is thrown via ::throwSecurityError, and _careful_
   // consideration must be given to the data exposed to JavaScript via the
   // 'sanitizedMessage'.
   DCHECK(ec != SecurityError);
 
+  if (!shouldThrow())
+    return;
+
   const String& processedMessage = addExceptionContext(message);
   setException(ec, processedMessage, V8ThrowException::createDOMException(
                                          m_isolate, ec, processedMessage));
 }
 
 void ExceptionState::throwRangeError(const String& message) {
+  if (!shouldThrow())
+    return;
+
   setException(V8RangeError, message,
                V8ThrowException::createRangeError(
                    m_isolate, addExceptionContext(message)));
 }
 
 void ExceptionState::throwSecurityError(const String& sanitizedMessage,
                                         const String& unsanitizedMessage) {
+  if (!shouldThrow())
+    return;
+
   const String& finalSanitized = addExceptionContext(sanitizedMessage);
   const String& finalUnsanitized = addExceptionContext(unsanitizedMessage);
   setException(SecurityError, finalSanitized,
                V8ThrowException::createDOMException(
                    m_isolate, SecurityError, finalSanitized, finalUnsanitized));
 }
 
 void ExceptionState::throwTypeError(const String& message) {
+  if (!shouldThrow())
+    return;
+
   setException(V8TypeError, message,
                V8ThrowException::createTypeError(m_isolate,
                                                  addExceptionContext(message)));
 }
 
 void ExceptionState::rethrowV8Exception(v8::Local<v8::Value> value) {
+  if (!shouldThrow())
+    return;
+
   setException(kRethrownException, String(), value);
 }
 
 void ExceptionState::clearException() {
   m_code = 0;
   m_message = String();
   m_exception.clear();
 }
 
 ScriptPromise ExceptionState::reject(ScriptState* scriptState) {
@@ skipping 64 matching lines @@
     : ExceptionState(nullptr, ExceptionState::UnknownContext, nullptr, nullptr),
       m_file(""),
       m_line(0) {}
 
 NonThrowableExceptionState::NonThrowableExceptionState(const char* file,
                                                        int line)
     : ExceptionState(nullptr, ExceptionState::UnknownContext, nullptr, nullptr),
       m_file(file),
       m_line(line) {}
 
-void NonThrowableExceptionState::throwDOMException(ExceptionCode ec,
-                                                   const String& message) {
-  DCHECK_AT(false, m_file, m_line) << "DOMExeption should not be thrown.";
+bool NonThrowableExceptionState::shouldThrow() const {
+  DCHECK_AT(false, m_file, m_line) << "An exception should not be thrown.";
+  return false;
 }
 
-void NonThrowableExceptionState::throwRangeError(const String& message) {
-  DCHECK_AT(false, m_file, m_line) << "RangeError should not be thrown.";
-}
-
-void NonThrowableExceptionState::throwSecurityError(
-    const String& sanitizedMessage,
-    const String&) {
-  DCHECK_AT(false, m_file, m_line) << "SecurityError should not be thrown.";
-}
-
-void NonThrowableExceptionState::throwTypeError(const String& message) {
-  DCHECK_AT(false, m_file, m_line) << "TypeError should not be thrown.";
-}
-
-void NonThrowableExceptionState::rethrowV8Exception(v8::Local<v8::Value>) {
-  DCHECK_AT(false, m_file, m_line) << "An exception should not be rethrown.";
-}
-
-void DummyExceptionStateForTesting::throwDOMException(ExceptionCode ec,
-                                                      const String& message) {
-  setException(ec, message, v8::Local<v8::Value>());
-}
-
-void DummyExceptionStateForTesting::throwRangeError(const String& message) {
-  setException(V8RangeError, message, v8::Local<v8::Value>());
-}
-
-void DummyExceptionStateForTesting::throwSecurityError(
-    const String& sanitizedMessage,
-    const String&) {
-  setException(SecurityError, sanitizedMessage, v8::Local<v8::Value>());
-}
-
-void DummyExceptionStateForTesting::throwTypeError(const String& message) {
-  setException(V8TypeError, message, v8::Local<v8::Value>());
-}
-
-void DummyExceptionStateForTesting::rethrowV8Exception(v8::Local<v8::Value>) {
-  setException(kRethrownException, String(), v8::Local<v8::Value>());
+bool DummyExceptionStateForTesting::shouldThrow() const {
+  // This class ignores all exceptions.
+  return false;
 }
 
 }  // namespace blink