Devirtualize ExceptionState's helper throwing methods.

third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 43 matching lines @@
   throwTypeError(String(message));
 }
 
 void ExceptionState::throwDOMException(ExceptionCode ec,
                                        const String& message) {
   // SecurityError is thrown via ::throwSecurityError, and _careful_
   // consideration must be given to the data exposed to JavaScript via the
   // 'sanitizedMessage'.
   DCHECK(ec != SecurityError);
 
   const String& processedMessage = addExceptionContext(message);

[dcheng, 2017/02/25 12:02:35]

The alternative here is to consult a new policy virtual (shouldThrow?) before
building the exception message.

   setException(ec, processedMessage, V8ThrowException::createDOMException(
                                          m_isolate, ec, processedMessage));
 }
 
 void ExceptionState::throwRangeError(const String& message) {
   setException(V8RangeError, message,
                V8ThrowException::createRangeError(
                    m_isolate, addExceptionContext(message)));
 }
 
@@ skipping 90 matching lines @@
     : ExceptionState(nullptr, ExceptionState::UnknownContext, nullptr, nullptr),
       m_file(""),
       m_line(0) {}
 
 NonThrowableExceptionState::NonThrowableExceptionState(const char* file,
                                                        int line)
     : ExceptionState(nullptr, ExceptionState::UnknownContext, nullptr, nullptr),
       m_file(file),
       m_line(line) {}
 
-void NonThrowableExceptionState::throwDOMException(ExceptionCode ec,
-                                                   const String& message) {
-  DCHECK_AT(false, m_file, m_line) << "DOMExeption should not be thrown.";
-}
-
-void NonThrowableExceptionState::throwRangeError(const String& message) {
-  DCHECK_AT(false, m_file, m_line) << "RangeError should not be thrown.";
-}
-
-void NonThrowableExceptionState::throwSecurityError(
-    const String& sanitizedMessage,
-    const String&) {
-  DCHECK_AT(false, m_file, m_line) << "SecurityError should not be thrown.";
-}
-
-void NonThrowableExceptionState::throwTypeError(const String& message) {
-  DCHECK_AT(false, m_file, m_line) << "TypeError should not be thrown.";
-}
-
-void NonThrowableExceptionState::rethrowV8Exception(v8::Local<v8::Value>) {
+void NonThrowableExceptionState::setException(ExceptionCode ec,
+                                              const String& message,
+                                              v8::Local<v8::Value> exception) {
   DCHECK_AT(false, m_file, m_line) << "An exception should not be rethrown.";
 }
 
-void DummyExceptionStateForTesting::throwDOMException(ExceptionCode ec,
-                                                      const String& message) {
-  setException(ec, message, v8::Local<v8::Value>());
-}
-
-void DummyExceptionStateForTesting::throwRangeError(const String& message) {
-  setException(V8RangeError, message, v8::Local<v8::Value>());
-}
-
-void DummyExceptionStateForTesting::throwSecurityError(
-    const String& sanitizedMessage,
-    const String&) {
-  setException(SecurityError, sanitizedMessage, v8::Local<v8::Value>());
-}
-
-void DummyExceptionStateForTesting::throwTypeError(const String& message) {
-  setException(V8TypeError, message, v8::Local<v8::Value>());
-}
-
-void DummyExceptionStateForTesting::rethrowV8Exception(v8::Local<v8::Value>) {
-  setException(kRethrownException, String(), v8::Local<v8::Value>());
+void DummyExceptionStateForTesting::setException(
+    ExceptionCode ec,
+    const String& message,
+    v8::Local<v8::Value> exception) {
+  // Ignored.
 }
 
 }  // namespace blink