Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: src/debug.h

Issue 2715004: [Isolates]... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/isolates/
Patch Set: Address comments/make StackGuard::ThreadLocal::Initialize/Clear side-effects visible Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler.cc ('k') | src/debug.cc » ('j') | src/execution.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.h
===================================================================
--- src/debug.h (revision 4831)
+++ src/debug.h (working copy)
@@ -780,6 +780,10 @@
}
~EnterDebugger() {
+ // TODO(isolates): Check to see if this is the same isolate as in the
+ // constructor.
+ Isolate* isolate = Isolate::Current();
+
// Restore to the previous break state.
Debug::SetBreak(break_frame_id_, break_id_);
@@ -792,9 +796,9 @@
if (!Top::has_pending_exception()) {
// Try to avoid any pending debug break breaking in the clear mirror
// cache JavaScript code.
- if (StackGuard::IsDebugBreak()) {
+ if (isolate->stack_guard()->IsDebugBreak()) {
Debug::set_interrupts_pending(DEBUGBREAK);
- StackGuard::Continue(DEBUGBREAK);
+ isolate->stack_guard()->Continue(DEBUGBREAK);
}
Debug::ClearMirrorCache();
}
@@ -805,17 +809,17 @@
// This re-scheduling of preemption is to avoid starvation in some
// debugging scenarios.
Debug::clear_interrupt_pending(PREEMPT);
- StackGuard::Preempt();
+ isolate->stack_guard()->Preempt();
}
if (Debug::is_interrupt_pending(DEBUGBREAK)) {
Debug::clear_interrupt_pending(DEBUGBREAK);
- StackGuard::DebugBreak();
+ isolate->stack_guard()->DebugBreak();
}
// If there are commands in the queue when leaving the debugger request
// that these commands are processed.
if (Debugger::HasCommands()) {
- StackGuard::DebugCommand();
+ isolate->stack_guard()->DebugCommand();
}
// If leaving the debugger with the debugger no longer active unload it.
« no previous file with comments | « src/assembler.cc ('k') | src/debug.cc » ('j') | src/execution.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698