Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: src/debug.cc

Issue 2715004: [Isolates]... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/isolates/
Patch Set: Address comments/make StackGuard::ThreadLocal::Initialize/Clear side-effects visible Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/debug.h ('k') | src/execution.h » ('j') | src/execution.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2193 matching lines...) Expand 10 before | Expand all | Expand 10 after
2204 case v8::NewFunction: 2204 case v8::NewFunction:
2205 break; 2205 break;
2206 default: 2206 default:
2207 UNREACHABLE(); 2207 UNREACHABLE();
2208 } 2208 }
2209 2209
2210 // The debug command interrupt flag might have been set when the command was 2210 // The debug command interrupt flag might have been set when the command was
2211 // added. It should be enough to clear the flag only once while we are in the 2211 // added. It should be enough to clear the flag only once while we are in the
2212 // debugger. 2212 // debugger.
2213 ASSERT(Debug::InDebugger()); 2213 ASSERT(Debug::InDebugger());
2214 StackGuard::Continue(DEBUGCOMMAND); 2214 Isolate::Current()->stack_guard()->Continue(DEBUGCOMMAND);
2215 2215
2216 // Notify the debugger that a debug event has occurred unless auto continue is 2216 // Notify the debugger that a debug event has occurred unless auto continue is
2217 // active in which case no event is send. 2217 // active in which case no event is send.
2218 if (sendEventMessage) { 2218 if (sendEventMessage) {
2219 MessageImpl message = MessageImpl::NewEvent( 2219 MessageImpl message = MessageImpl::NewEvent(
2220 event, 2220 event,
2221 auto_continue, 2221 auto_continue,
2222 Handle<JSObject>::cast(exec_state), 2222 Handle<JSObject>::cast(exec_state),
2223 Handle<JSObject>::cast(event_data)); 2223 Handle<JSObject>::cast(event_data));
2224 InvokeMessageHandler(message); 2224 InvokeMessageHandler(message);
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
2446 CommandMessage message = CommandMessage::New( 2446 CommandMessage message = CommandMessage::New(
2447 Vector<uint16_t>(const_cast<uint16_t*>(command.start()), 2447 Vector<uint16_t>(const_cast<uint16_t*>(command.start()),
2448 command.length()), 2448 command.length()),
2449 client_data); 2449 client_data);
2450 Logger::DebugTag("Put command on command_queue."); 2450 Logger::DebugTag("Put command on command_queue.");
2451 command_queue_.Put(message); 2451 command_queue_.Put(message);
2452 command_received_->Signal(); 2452 command_received_->Signal();
2453 2453
2454 // Set the debug command break flag to have the command processed. 2454 // Set the debug command break flag to have the command processed.
2455 if (!Debug::InDebugger()) { 2455 if (!Debug::InDebugger()) {
2456 StackGuard::DebugCommand(); 2456 Isolate::Current()->stack_guard()->DebugCommand();
2457 } 2457 }
2458 2458
2459 MessageDispatchHelperThread* dispatch_thread; 2459 MessageDispatchHelperThread* dispatch_thread;
2460 { 2460 {
2461 ScopedLock with(dispatch_handler_access_); 2461 ScopedLock with(dispatch_handler_access_);
2462 dispatch_thread = message_dispatch_helper_thread_; 2462 dispatch_thread = message_dispatch_helper_thread_;
2463 } 2463 }
2464 2464
2465 if (dispatch_thread == NULL) { 2465 if (dispatch_thread == NULL) {
2466 CallMessageDispatchHandler(); 2466 CallMessageDispatchHandler();
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
2855 { 2855 {
2856 Locker locker; 2856 Locker locker;
2857 Debugger::CallMessageDispatchHandler(); 2857 Debugger::CallMessageDispatchHandler();
2858 } 2858 }
2859 } 2859 }
2860 } 2860 }
2861 2861
2862 #endif // ENABLE_DEBUGGER_SUPPORT 2862 #endif // ENABLE_DEBUGGER_SUPPORT
2863 2863
2864 } } // namespace v8::internal 2864 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/debug.h ('k') | src/execution.h » ('j') | src/execution.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698