Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2714943004: Move unique name generation and tracking into //content. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrameClient.h
diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h
index 5bf558bdb55eb59a54a0fdb1fa37d2ecc475dc43..6c1ee8a95ddcb6f1b2df06d861c2cff0b1b2e75f 100644
--- a/third_party/WebKit/public/web/WebFrameClient.h
+++ b/third_party/WebKit/public/web/WebFrameClient.h
@@ -180,7 +180,7 @@ class BLINK_EXPORT WebFrameClient {
virtual WebLocalFrame* createChildFrame(WebLocalFrame* parent,
WebTreeScopeType,
const WebString& name,
- const WebString& uniqueName,
+ const WebString& fallbackName,
dcheng 2017/03/01 23:57:26 Note: I'm 95% sure this isn't actually needed: whe
WebSandboxFlags sandboxFlags,
const WebFrameOwnerProperties&) {
return nullptr;
@@ -206,8 +206,7 @@ class BLINK_EXPORT WebFrameClient {
virtual void willCommitProvisionalLoad(WebLocalFrame*) {}
// This frame's name has changed.
- virtual void didChangeName(const WebString& name,
- const WebString& uniqueName) {}
+ virtual void didChangeName(const WebString& name) {}
// This frame has set an insecure request policy.
virtual void didEnforceInsecureRequestPolicy(WebInsecureRequestPolicy) {}

Powered by Google App Engine
This is Rietveld 408576698