Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.h

Issue 2714943004: Move unique name generation and tracking into //content. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.h
diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.h b/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
index d0492282c2d19f34b508a5140d762fa7b5bdba55..87a8cf250788a911194bb1e222c8540b2584ce1c 100644
--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
@@ -35,7 +35,6 @@ class WEB_EXPORT WebRemoteFrameImpl final
// WebFrame methods:
void close() override;
- WebString uniqueName() const override;
WebString assignedName() const override;
void setName(const WebString&) override;
WebVector<WebIconURL> iconURLs(int iconTypesMask) const override;
@@ -113,8 +112,7 @@ class WEB_EXPORT WebRemoteFrameImpl final
// WebFrameImplBase methods:
void initializeCoreFrame(FrameHost*,
FrameOwner*,
- const AtomicString& name,
- const AtomicString& uniqueName) override;
+ const AtomicString& name) override;
RemoteFrame* frame() const override { return m_frame.get(); }
void setCoreFrame(RemoteFrame*);
@@ -126,7 +124,6 @@ class WEB_EXPORT WebRemoteFrameImpl final
// WebRemoteFrame methods:
WebLocalFrame* createLocalChild(WebTreeScopeType,
const WebString& name,
- const WebString& uniqueName,
WebSandboxFlags,
WebFrameClient*,
blink::InterfaceProvider*,
@@ -136,27 +133,23 @@ class WEB_EXPORT WebRemoteFrameImpl final
WebFrame* opener) override;
WebRemoteFrame* createRemoteChild(WebTreeScopeType,
const WebString& name,
- const WebString& uniqueName,
WebSandboxFlags,
WebRemoteFrameClient*,
WebFrame* opener) override;
void setWebLayer(WebLayer*) override;
- void setReplicatedOrigin(const WebSecurityOrigin&) const override;
- void setReplicatedSandboxFlags(WebSandboxFlags) const override;
- void setReplicatedName(const WebString& name,
- const WebString& uniqueName) const override;
+ void setReplicatedOrigin(const WebSecurityOrigin&) override;
+ void setReplicatedSandboxFlags(WebSandboxFlags) override;
+ void setReplicatedName(const WebString&) override;
void setReplicatedFeaturePolicyHeader(
- const WebParsedFeaturePolicyHeader& parsedHeader) const override;
+ const WebParsedFeaturePolicyHeader& parsedHeader) override;
void addReplicatedContentSecurityPolicyHeader(
const WebString& headerValue,
WebContentSecurityPolicyType,
- WebContentSecurityPolicySource) const override;
- void resetReplicatedContentSecurityPolicy() const override;
- void setReplicatedInsecureRequestPolicy(
- WebInsecureRequestPolicy) const override;
- void setReplicatedPotentiallyTrustworthyUniqueOrigin(bool) const override;
- void dispatchLoadEventOnFrameOwner() const override;
-
+ WebContentSecurityPolicySource) override;
+ void resetReplicatedContentSecurityPolicy() override;
+ void setReplicatedInsecureRequestPolicy(WebInsecureRequestPolicy) override;
+ void setReplicatedPotentiallyTrustworthyUniqueOrigin(bool) override;
+ void dispatchLoadEventOnFrameOwner() override;
void didStartLoading() override;
void didStopLoading() override;

Powered by Google App Engine
This is Rietveld 408576698