Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: third_party/WebKit/public/web/WebHistoryItem.h

Issue 2714943004: Move unique name generation and tracking into //content. (Closed)
Patch Set: Rebase again. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/web/WebFrameClient.h ('k') | third_party/WebKit/public/web/WebRemoteFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebHistoryItem.h
diff --git a/third_party/WebKit/public/web/WebHistoryItem.h b/third_party/WebKit/public/web/WebHistoryItem.h
index 39e53401664ff44e5c837cc5eeaa068e21f5db71..109c3c1be9a659e59bc7887adb8fb8d3061d912e 100644
--- a/third_party/WebKit/public/web/WebHistoryItem.h
+++ b/third_party/WebKit/public/web/WebHistoryItem.h
@@ -35,6 +35,7 @@
#include "../platform/WebHistoryScrollRestorationType.h"
#include "../platform/WebPrivatePtr.h"
#include "../platform/WebReferrerPolicy.h"
+#include "public/platform/WebString.h"
namespace blink {
@@ -81,7 +82,7 @@ class WebHistoryItem {
BLINK_EXPORT WebReferrerPolicy getReferrerPolicy() const;
BLINK_EXPORT void setReferrer(const WebString&, WebReferrerPolicy);
- BLINK_EXPORT WebString target() const;
+ BLINK_EXPORT const WebString& target() const;
BLINK_EXPORT void setTarget(const WebString&);
BLINK_EXPORT WebFloatPoint visualViewportScrollOffset() const;
@@ -127,6 +128,8 @@ class WebHistoryItem {
private:
WebPrivatePtr<HistoryItem> m_private;
+ // TODO(dcheng): Remove this, since unique name is no longer a Blink concept.
+ WebString m_target;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/public/web/WebFrameClient.h ('k') | third_party/WebKit/public/web/WebRemoteFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698