Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2714943004: Move unique name generation and tracking into //content. (Closed)
Patch Set: Rebase again. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 9e68ace225ac574b9e4e33572761c1f5620e7f9b..72607ea90554fa526b984bf96f5447cc1da0990b 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -3219,7 +3219,7 @@ class CreateChildCounterFrameClient
WebLocalFrame* createChildFrame(WebLocalFrame* parent,
WebTreeScopeType,
const WebString& name,
- const WebString& uniqueName,
+ const WebString& fallbackName,
WebSandboxFlags,
const WebFrameOwnerProperties&) override;
@@ -3233,12 +3233,12 @@ WebLocalFrame* CreateChildCounterFrameClient::createChildFrame(
WebLocalFrame* parent,
WebTreeScopeType scope,
const WebString& name,
- const WebString& uniqueName,
+ const WebString& fallbackName,
WebSandboxFlags sandboxFlags,
const WebFrameOwnerProperties& frameOwnerProperties) {
++m_count;
return TestWebFrameClient::createChildFrame(
- parent, scope, name, uniqueName, sandboxFlags, frameOwnerProperties);
+ parent, scope, name, fallbackName, sandboxFlags, frameOwnerProperties);
}
TEST_P(WebViewTest, ChangeDisplayMode) {
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/Source/web/tests/data/frameset-dest.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698